Skip to content

feat(delete collections): remove collections from the tool#1271

Merged
jpetto merged 2 commits intomainfrom
HNT-1730-remove-collections
Feb 24, 2026
Merged

feat(delete collections): remove collections from the tool#1271
jpetto merged 2 commits intomainfrom
HNT-1730-remove-collections

Conversation

@jpetto
Copy link
Collaborator

@jpetto jpetto commented Feb 23, 2026

Goal

remove collections management from the admin tools. collections are being torn down as part of the larger pocket decommission.

  • pocket decommission
  • HNT-1730
  • fix lint issues
  • update README
  • add allowAds and followable where necessary for type checking on Sections

Todos

  • push to dev

Reference

Tickets:

Implementation Decisions

  • kept some helper files/functions that are not in use after removing collections code. idea here is these helpers seemed general purpose enough that they're worth keeping around instead of being forgotten in git history. happy to delete them though if we want purity.

@jpetto jpetto force-pushed the HNT-1730-remove-collections branch 3 times, most recently from 9909904 to a4b0cc5 Compare February 23, 2026 20:02
@jpetto jpetto closed this Feb 23, 2026
@jpetto jpetto reopened this Feb 23, 2026
@jpetto jpetto marked this pull request as ready for review February 23, 2026 20:10
@jpetto jpetto requested a review from a team as a code owner February 23, 2026 20:10
Copy link
Contributor

@mmiermans mmiermans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Nice work. I asked Claude to look for more collection-related code that can be removed. According to Claude, the following code/packages are unused now that collections is going away. Could you double-check and remove if so?

Files to delete

Path Why dead
src/_shared/components/MarkdownPreview/ No consumers
src/_shared/components/TabSet/ Only used by MarkdownPreview
src/_shared/components/TabPanel/ Only used by MarkdownPreview
src/_shared/components/TabNavigation/ Only used by TabSet
src/_shared/components/Tab/ Only used by TabSet + TabNavigation
src/_shared/components/LoadMore/ No consumers
src/_shared/components/ScrollToTop/ No consumers
src/_shared/hooks/useFetchMoreResults/ No consumers
src/_shared/styled/StyledCardLink.tsx No consumers
src/_shared/styled/StyledChipComponent.tsx No consumers

Dead config

Remove the slugify block in src/config/index.ts (lines 47-55) — nothing reads config.slugify anymore.

Barrel export removals

src/_shared/components/index.ts: Remove exports for LoadMore, MarkdownPreview, ScrollToTop, Tab, TabNavigation, TabPanel, TabSet, CustomTabType

src/_shared/styled/index.ts: Remove exports for StyledCardLink, StyledChipComponent

Packages to remove from package.json

  • react-markdown (6.0.3) — sole consumer was MarkdownPreview
  • react-beautiful-dnd (13.1.1) — sole consumer was ReorderableCollectionStoryList
  • @types/react-beautiful-dnd (13.1.4) — type defs for the above
  • slugify (1.6.6) — sole consumer was collections slug generation

import { useNotifications } from '../';

// 2026-02-23: after removing collections, this function is not currently in
// use. leaving this in the code base as we may again need this functionality.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete this unused code. It should be fairly easy to recreate similar code if we ever need it again.

@jpetto jpetto force-pushed the HNT-1730-remove-collections branch 3 times, most recently from c7213bc to 6229a27 Compare February 23, 2026 23:50
- pocket decommission
- HNT-1730
- fix lint issues
- update README
- add allowAds and followable to satisfy sections type checking
- delete more unused files and imports
- delete unused config
@jpetto jpetto force-pushed the HNT-1730-remove-collections branch from 6229a27 to dd04b05 Compare February 24, 2026 00:00
Copy link
Contributor

@mmiermans mmiermans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jpetto jpetto merged commit 6ef2359 into main Feb 24, 2026
10 checks passed
@jpetto jpetto deleted the HNT-1730-remove-collections branch February 24, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants