Skip to content

Comments

Fix default filters#552

Open
IdrissaD wants to merge 4 commits intoPnX-SI:developfrom
naturalsolutions:fix_default_filters
Open

Fix default filters#552
IdrissaD wants to merge 4 commits intoPnX-SI:developfrom
naturalsolutions:fix_default_filters

Conversation

@IdrissaD
Copy link

Fixes #551

Parallèlement, la méthode clearFilters était appelée deux fois par ngOnChanges et initDatatable, j'ai donc supprimé son appel de initDatatable car ngOnChanges est déjà appelée au chargement.

@IdrissaD IdrissaD force-pushed the fix_default_filters branch from cf0685d to 2b2deb6 Compare January 19, 2026 13:56
@camillemonchicourt
Copy link
Member

OK merci.
Y a un problème de lint ?

@IdrissaD
Copy link
Author

Oui, j'ai du mal à comprendre pourquoi sachant que je n'ai modifié qu'un fichier du front. J'ai vérifié en local les fichiers signalés par la GitHub Action et ils sont déjà formattés selon Black.

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ad62b80) to head (6f7513c).
⚠️ Report is 28 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #552   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            4         4           
=========================================
  Hits             4         4           
Flag Coverage Δ
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants