Feat: add config dynamic synthese module filters#472
Draft
andriacap wants to merge 2 commits intoPnX-SI:developfrom
Draft
Feat: add config dynamic synthese module filters#472andriacap wants to merge 2 commits intoPnX-SI:developfrom
andriacap wants to merge 2 commits intoPnX-SI:developfrom
Conversation
- Add dynamic_form_def for each protocol - Call config for each protocol and get all fields from observation config (only observation because of information send to synthese) - Enrich function allow to merge config monitoring dynamic_form_def and observation.json config Reviewed-by: @acapai
- remove route _internal/modules instead use get_modules function - add parameters in config example and in conf_schema --> allow to display conditionnaly advanced filters Reviewed-by: @acapai
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #472 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 4 4
=========================================
Hits 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cette PR propose une implémentation de nouveaux champs dans la configuration du module monitoring afin de pouvoir filtrer sur les champs additionnels qui sont envoyé dans la synthese .
Les développements proposés permettent d'utiliser le fichier
observation.jsonde chaque protocole pour pouvoir enrichier les filtres que l'on souhaite afficher dans le module de synthèse.Une explication plus détaillée a été rédigée ici dans le dépot de GeoNature : PnX-SI/GeoNature#3662 .
Les développements proposés peuvent certainement être améliorés. Je suis disponible pour discuter , échanger et ouvert à toute suggestion d'amélioraiton . Vous pouvez tester les développements en utilisant les deux branches suivantes liées à la PR coté GeoNature :
Ainsi que la branche liée à cette PR coté monitoring .