Open
Conversation
Frontend check only site with childs from specific protocol. If one site has visit in another protocol you can delete the site because in this specific protocol there are no visit. - Add check backend on route delete Reviewed-by: andriacap
- test backend to check http response with code 403 and error message Reviewed-by: andriacap
Reviewed-by: andriac
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #429 +/- ##
===========================================
- Coverage 75.93% 75.31% -0.62%
===========================================
Files 30 30
Lines 2410 2443 +33
===========================================
+ Hits 1830 1840 +10
- Misses 580 603 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Il y a un problème avec le codecov étant donné que des tests ont été ajoutés dans la PR et que les lignes ajoutées sont couvertes par les tests. |
Contributor
|
top, je me demande si il ne faudrait pas également considérer le cas pour les groupes de sites. Pour le front, il faudrait peut être remonter un paramètre nb_visits_total de façon à bloquer la suppression de façon à éviter à l'utilisateur un message d'erreur |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cette PR propose de régler le problème lié à la possibilité de supprimer un site partagé entre deux ou plusieurs modules alors que ce dernier à un au moins une visite dans un de ces modules.
Voir issue : #417
Close: #417