Adapt OpenSubDiv to use CudaToolkit instead of Cuda#1369
Open
danrbailey wants to merge 1 commit intoPixarAnimationStudios:devfrom
Open
Adapt OpenSubDiv to use CudaToolkit instead of Cuda#1369danrbailey wants to merge 1 commit intoPixarAnimationStudios:devfrom
danrbailey wants to merge 1 commit intoPixarAnimationStudios:devfrom
Conversation
Signed-off-by: Dan Bailey <danbailey@ilm.com>
Member
|
Filed as internal issue #OSD-468 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the more modern way of finding the Cuda Toolkit which uses target-based linking. It also takes advantage of Cuda being a first-class language in CMake. The legacy
find_package(Cuda)mechanism used in OpenSubdiv is now deprecated. We have found this to work more reliably with later versions of Cuda on Linux.This does however require a bump from 3.14 to 3.17 as the minimum CMake version.