Improved osd patch basis compatibility#1321
Merged
davidgyu merged 2 commits intoPixarAnimationStudios:devfrom Sep 14, 2023
Merged
Improved osd patch basis compatibility#1321davidgyu merged 2 commits intoPixarAnimationStudios:devfrom
davidgyu merged 2 commits intoPixarAnimationStudios:devfrom
Conversation
Folded osd/patchBasisCommon.h and osd/patchBasisCommonEval.h into the single header file osd/patchBasis.h and renamed osd/PatchBasisCommonTypes.h to osd/patchBasisTypes.h Moved these into the OpenSubdiv::Osd namespace when compiled for C++ and added a brief comment describing the intended use cases for this code.
Providing these as public headers in opensubdiv/osd allows client code to implement evaluation kernels in their own TBB, CUDA, OMP, GCD, etc. code without needing an implementation within the osd codebase. Tested with C++, CUDA, and oneTBB client kernels.
davidgyu
force-pushed
the
dev_osd_patch_basis_compatibility
branch
from
48be18c to
be4c718
Compare
Member
Author
|
Reviewed internally along with additional testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitted as two commits for a cleaner commit history.
--
Reorganized osd/patchBasis and osd/patchBasisTypes
Folded osd/patchBasisCommon.h and osd/patchBasisCommonEval.h into the
single header file osd/patchBasis.h and renamed osd/PatchBasisCommonTypes.h
to osd/patchBasisTypes.h
Moved these into the OpenSubdiv::Osd namespace when compiled for C++ and
added a brief comment describing the intended use cases for this code.
--
Installed osd/patchBasis.h and osd/patchBasisTypes.h
Providing these as public headers in opensubdiv/osd allows client code
to implement evaluation kernels in their own TBB, CUDA, OMP, GCD, etc.
code without needing an implementation within the osd codebase.
Tested with C++, CUDA, and oneTBB client kernels.
Fixes #938 #1153