Improved osd patch drawing compatibility#1320
Merged
davidgyu merged 2 commits intoPixarAnimationStudios:devfrom Sep 14, 2023
Merged
Improved osd patch drawing compatibility#1320davidgyu merged 2 commits intoPixarAnimationStudios:devfrom
davidgyu merged 2 commits intoPixarAnimationStudios:devfrom
Conversation
Relocated from PatchCommon to PatchLegacy several aspects of the shader source which can cause problems with typical use cases. Specifically, things like resource bindings, input assembler and interstage declarations are best left to client code. These are not removed, just relocated and remain available for backward compatibility. Updated the GLSL, HLSL, and MSL source.
This is a new method for GLSL, HLSL, and MSL which returns patch drawing shader source which excludes legacy shader source aspects. This improves portability and compatibility and may also improve shader compile times since the resulting shader source strings are smaller without the legacy shader source aspects. Tested with Vulkan and DX12 in addition to GL, DX11, and Metal.
Member
Author
|
Reviewed internally along with additional testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitted as two commits for a cleaner commit history.
--
Reorganized legacy patch drawing shader source
Relocated from PatchCommon to PatchLegacy several aspects of the
shader source which can cause problems with typical use cases.
Specifically, things like resource bindings, input assembler and
interstage declarations are best left to client code.
These are not removed, just relocated and remain available for
backward compatibility. Updated the GLSL, HLSL, and MSL source.
--
Added GetPatchDrawingShaderSource()
This is a new method for GLSL, HLSL, and MSL which returns patch
drawing shader source which excludes legacy shader source aspects.
This improves portability and compatibility and may also improve
shader compile times since the resulting shader source strings
are smaller without the legacy shader source aspects.
Tested with Vulkan and DX12 in addition to GL, DX11, and Metal.
Fixes #938 #1153