Open
Conversation
- Updated the unit tests to have return type of void - Replaced usages of assertInternalType() due to deprecation - Changed the minimum PHP version to 7.2
OAFCROB
force-pushed
the
feature/upgrade-phpunit-to-8.4
branch
from
f02b16d to
3e3239c
Compare
Closed
Contributor
|
We still need 7.0 and 7.1 compatibility @OAFCROB |
Contributor
Author
|
@jonmilsom that's why the repository needs to be tagged up and you can simply reference the previous tag in the composer.json in the main Pitchero repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jonmilsom can you have a look at this PR and merge into master. You'll need to tag the master branch as well as I no longer have the admin rights for this.