Skip to content

fix(scripts): update ticdc publishing threshold to v8.5.4 #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 4 commits into from
Nov 27, 2025
Merged

fix(scripts): update ticdc publishing threshold to v8.5.4 #3920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8ef1fb
fix(scripts): update ticdc publishing threshold to v8.5.4
wuhuizuo Nov 27, 2025
e375968
Update scripts/artifacts/tag-rc2ga-on-repos.sh
wuhuizuo Nov 27, 2025
22d31f6
Update scripts/artifacts/tag-rc2ga-on-repos.sh
wuhuizuo Nov 27, 2025
d24ee8a
Fix ticdc version boundary check
wuhuizuo Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scripts/artifacts/tag-rc2ga-on-repos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ function tag_oci_artifact_repos() {
"pingcap/tidb-binlog/package"
)
fi
# pingcap/ticdc/package published since v9.0.0
if [[ "$(printf '%s\n' "v9.0.0" "$ga_ver" | sort -V | head -n1)" == "v9.0.0" ]]; then
# pingcap/ticdc/package published since v8.5.4
if [[ "$(printf '%s\n' "v8.5.4" "$ga_ver" | sort -V | tail -n1)" == "$ga_ver" ]]; then
repos+=(
"pingcap/ticdc/package"
)
Expand Down Expand Up @@ -115,8 +115,8 @@ function tag_oci_image_repos() {
"pingcap/tidb-binlog/image"
)
fi
# ticdc will publish from ticdc repo since v9.0.0
if [[ "$(printf '%s\n' "v9.0.0" "$ga_ver" | sort -V | head -n1)" == "v9.0.0" ]]; then
# ticdc will publish from ticdc repo since v8.5.4
if [[ "$(printf '%s\n' "v8.5.4" "$ga_ver" | sort -V | tail -n1)" == "$ga_ver" ]]; then
# remove "pingcap/tiflow/images/cdc":
images=("${images[@]/pingcap\/tiflow\/images\/cdc/}")
# Filter out empty elements that might result from the removal
Expand Down
6 changes: 3 additions & 3 deletions scripts/flow/ga/collect-info-for-release-issue.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#! /usr/bin/env bash
# This script collects information about the current release and generates markdown for release issues.

previous_release="v8.5.1" # comment it when current release is not a patch release.
current_release="v8.5.2"
previous_release="v8.5.3" # comment it when current release is not a patch release.
current_release="v8.5.4"

### !!! Please update the list of repositories before running this script.
repos=(
Expand All @@ -15,7 +15,7 @@ repos=(
pingcap/ng-monitoring
pingcap/tidb-dashboard

pingcap/ticdc # started since v9.0.0
pingcap/ticdc # started since v8.5.4
pingcap/tidb-tools # migrated to pingcap/tiflow since v9.0.0
pingcap/tidb-binlog # deprecated since v8.3.0
)
Expand Down
2 changes: 1 addition & 1 deletion scripts/flow/rc/check-images-internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ async function checkImages(
if (version >= "v8.4.0" && gitRepo === "pingcap/tidb-binlog") {
continue;
}
// ticdc is initilized since v9.0.0
// ticdc is initilized since v8.5.4
Comment thread
wuhuizuo marked this conversation as resolved.
if (version <= "v8.5.3" && gitRepo === "pingcap/ticdc") {
continue;
}
Expand Down
4 changes: 2 additions & 2 deletions scripts/flow/rc/check-tiup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,8 @@ async function main(
if (version >= "v8.4.0" && ociRepo === "pingcap/tidb-binlog/package") {
continue;
}
// ticdc is initilized since v9.0.0
if (version <= "v9.0.0" && ociRepo === "pingcap/ticdc/package") {
// ticdc is initilized since v8.5.4
if (version < "v8.5.4" && ociRepo === "pingcap/ticdc/package") {
continue;
}

Expand Down