Skip to content

Conversation

@doup2001
Copy link
Member

@doup2001 doup2001 commented Jan 20, 2026

πŸ“Œ μž‘μ—…ν•œ λ‚΄μš©

λ¦¬λ‹€μ΄λ ‰νŠΈ μ£Όμ†Œλ₯Ό μ‹€μ œ μ„œλΉ„μŠ€ λ„λ©”μΈμœΌλ‘œ μ΄λ™ν•˜λ„λ‘ μˆ˜μ •ν•΄ 잘λͺ»λœ 경둜 μš”μ²­ μ‹œ μ˜¬λ°”λ₯Έ νŽ˜μ΄μ§€λ‘œ μ•ˆλ‚΄λ˜λ„λ‘ ν–ˆμŠ΅λ‹ˆλ‹€. CORS 섀정을 μΆ”κ°€ν•΄ ν”„λ‘ νŠΈμ—”λ“œ λ„λ©”μΈμ—μ„œμ˜ API 호좜이 μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ„λ‘ ν—ˆμš©ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ” μ°Έκ³  사항

  • λ¦¬λ‹€μ΄λ ‰νŠΈ: κΈ°μ‘΄ κ²½λ‘œλ‚˜ μž„μ‹œ μ£Όμ†Œ λŒ€μ‹  배포된 μ„œλΉ„μŠ€ 도메인 κΈ°μ€€μœΌλ‘œ 이동 처리.
  • CORS: ν”„λ‘ νŠΈμ—”λ“œ Origin을 ν—ˆμš© λͺ©λ‘μ— μΆ”κ°€ν•˜κ³ , ν•„μš”ν•œ λ©”μ„œλ“œ/헀더λ₯Ό μ—΄μ–΄ 개발·운영 ν™˜κ²½ λͺ¨λ‘μ—μ„œ 호좜 κ°€λŠ₯ν•˜λ„λ‘ ꡬ성.

πŸ–ΌοΈ μŠ€ν¬λ¦°μƒ·

UI λ³€κ²½ 사항 μ—†μŒ

πŸ”— κ΄€λ ¨ 이슈

μ„œλΉ„μŠ€ 배포 및 ν”„λ‘ νŠΈμ—”λ“œ 연동 κ΄€λ ¨ 이슈

βœ… 체크리슀트

  • 둜컬 및 μ„œλ²„ ν™˜κ²½μ—μ„œ λ¦¬λ‹€μ΄λ ‰νŠΈ λ™μž‘ 확인
  • ν—ˆμš© Originμ—μ„œ CORS μ—λŸ¬ λ―Έλ°œμƒ 확인
  • λ¬Έμ„œν™” ν•„μš” μ—¬λΆ€ 확인

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

μ›Œν¬μŠ€λ£¨

CORS 섀정에 ν”„λ‘œλ•μ…˜ ν”„λ‘ νŠΈμ—”λ“œ 원본을 μΆ”κ°€ν•˜κ³ , OAuth2 ν•Έλ“€λŸ¬μ˜ λ¦¬λ‹€μ΄λ ‰νŠΈ 경둜 μ„€μ • μ†ŒμŠ€λ₯Ό cors.front.localμ—μ„œ cors.front.redirect둜 λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€. μ΄λŠ” ν™˜κ²½λ³„ ꡬ성 관리λ₯Ό κ°œμ„ ν•˜κ³  ν”„λ‘œλ•μ…˜ 배포λ₯Ό μ§€μ›ν•©λ‹ˆλ‹€.

λ³€κ²½ 사항

μ½”ν˜ΈνŠΈ / 파일 λ³€κ²½ μš”μ•½
CORS μ„€μ • ν™•μž₯
src/main/java/com/pinHouse/server/security/config/CorsConfig.java
cors.front.prod μ„€μ • ν”„λ‘œνΌν‹°λ₯Ό λ‘œλ“œν•˜μ—¬ μƒˆλ‘œμš΄ ν”„λ‘œλ•μ…˜ ν”„λ‘ νŠΈμ—”λ“œ 원본을 ν—ˆμš© λͺ©λ‘μ— μΆ”κ°€
OAuth2 λ¦¬λ‹€μ΄λ ‰νŠΈ 경둜 톡합
src/main/java/com/pinHouse/server/security/oauth2/handler/OAuth2FailureHandler.java,
src/main/java/com/pinHouse/server/security/oauth2/handler/OAuth2SuccessHandler.java
@Value μ• λ„ˆν…Œμ΄μ…˜μ—μ„œ μ„€μ • ν‚€λ₯Ό ${cors.front.local}μ—μ„œ ${cors.front.redirect}둜 λ³€κ²½ν•˜μ—¬ 동적 λ¦¬λ‹€μ΄λ ‰νŠΈ 경둜 μ„€μ • 톡합

μ˜ˆμƒ μ½”λ“œ 리뷰 λ…Έλ ₯

🎯 2 (Simple) | ⏱️ ~8 λΆ„

μ‹œ

🐰 μ„€μ •μ˜ 경둜λ₯Ό λ‹€μ‹œ 그으며,
ν”„λ‘œλ•μ…˜μ˜ 문을 ν™œμ§ μ—΄κ³ ,
λ¦¬λ‹€μ΄λ ‰νŠΈμ˜ 흐름을 ν•˜λ‚˜λ‘œ λͺ¨μ•„,
ν™˜κ²½λ§ˆλ‹€ μš°μ•„ν•˜κ²Œ λ‹€λ£¨λŠ” λ§ˆλ²•,
ν•‘ν•˜μš°μŠ€μ˜ μ•ˆλ‚΄κ°€ λ”μš± λ§€λ„λŸ¬μ›Œμ§€λ„€! 🌟

πŸš₯ Pre-merge checks | βœ… 3
βœ… Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage βœ… Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check βœ… Passed PR 제λͺ©μ΄ λ³€κ²½ μ‚¬ν•­μ˜ μ£Όμš” λ‚΄μš©μ„ λͺ…ν™•ν•˜κ²Œ μš”μ•½ν•˜κ³  μžˆμŠ΅λ‹ˆλ‹€. '둜그인 λ¦¬λ‹€μ΄λ ‰νŠΈ μ‹€νŒ¨ 문제'λŠ” λ¦¬λ‹€μ΄λ ‰νŠΈ 경둜 λ³€κ²½ 및 CORS μ„€μ • μΆ”κ°€λ₯Ό 톡해 ν•΄κ²°ν•˜λ €λŠ” 핡심 문제λ₯Ό μ§μ ‘μ μœΌλ‘œ λ‚˜νƒ€λƒ…λ‹ˆλ‹€.
Description check βœ… Passed PR μ„€λͺ…이 ν…œν”Œλ¦Ώμ˜ λͺ¨λ“  μ£Όμš” μ„Ήμ…˜μ„ ν¬ν•¨ν•˜κ³  있으며, μž‘μ—… λ‚΄μš©, μ°Έκ³  사항, κ΄€λ ¨ 이슈, μ²΄ν¬λ¦¬μŠ€νŠΈκ°€ 적절히 μž‘μ„±λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • πŸ“ Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Test Results

22 tests  Β±0   22 βœ… Β±0   1s ⏱️ Β±0s
 3 suites Β±0    0 πŸ’€ Β±0 
 3 files   Β±0    0 ❌ Β±0 

Results for commit 36a9a92. ± Comparison against base commit 7dc4aa4.

♻️ This comment has been updated with latest results.

@doup2001 doup2001 changed the title Hotfix/λ¦¬λ‹€μ΄λ ‰νŠΈ πŸ”₯ hotfix: 둜그인 λ¦¬λ‹€μ΄λ ‰νŠΈ μ‹€νŒ¨ 문제 Jan 20, 2026
@doup2001 doup2001 merged commit 5b25fd0 into main Jan 20, 2026
3 of 4 checks passed
@doup2001 doup2001 deleted the hotfix/λ¦¬λ‹€μ΄λ ‰νŠΈ branch January 20, 2026 13:06
@doup2001 doup2001 restored the hotfix/λ¦¬λ‹€μ΄λ ‰νŠΈ branch January 20, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants