Add a Tree widget (when label is None and value ends with '.json' or '.xml' and when value is a dict)#67
Open
fgallaire wants to merge 15 commits intoPierreRaybaut:masterfrom
Open
Add a Tree widget (when label is None and value ends with '.json' or '.xml' and when value is a dict)#67fgallaire wants to merge 15 commits intoPierreRaybaut:masterfrom
fgallaire wants to merge 15 commits intoPierreRaybaut:masterfrom
Conversation
33fb3e8 to
e5cb27c
Compare
Owner
|
With Python 3.4.4 64bits on Windows: Traceback (most recent call last):
File "C:\Python\formlayout\examples\tree.py", line 37, in <module>
print('result:', fedit(datalist, title='Tree examples', type='questions'))
File "C:\Python\formlayout\formlayout.py", line 1285, in fedit
apply, ok, cancel, result, outfile, type, scrollbar)
File "C:\Python\formlayout\formlayout.py", line 1093, in __init__
self.formwidget.setup()
File "C:\Python\formlayout\formlayout.py", line 640, in setup
object_pairs_hook=OrderedDict)
File "C:\WinPython-64bit-3.4.4.3\python-3.4.4.amd64\lib\json\__init__.py", line 268, in load
parse_constant=parse_constant, object_pairs_hook=object_pairs_hook, **kw)
File "C:\WinPython-64bit-3.4.4.3\python-3.4.4.amd64\lib\json\__init__.py", line 331, in loads
return cls(**kw).decode(s)
File "C:\WinPython-64bit-3.4.4.3\python-3.4.4.amd64\lib\json\decoder.py", line 343, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "C:\WinPython-64bit-3.4.4.3\python-3.4.4.amd64\lib\json\decoder.py", line 361, in raw_decode
raise ValueError(errmsg("Expecting value", s, err.value)) from None
ValueError: Expecting value: line 1 column 1 (char 0) |
Collaborator
Author
|
I can't test my fix, so tell me if it's good. |
Owner
|
There is still the same traceback with Python 3.5: Traceback (most recent call last):
File "C:\Python\formlayout\examples\tree.py", line 37, in <module>
print('result:', fedit(datalist, title='Tree examples', type='questions'))
File "C:\Python\formlayout\formlayout.py", line 1289, in fedit
apply, ok, cancel, result, outfile, type, scrollbar)
File "C:\Python\formlayout\formlayout.py", line 1097, in __init__
self.formwidget.setup()
File "C:\Python\formlayout\formlayout.py", line 644, in setup
object_pairs_hook=OrderedDict)
File "C:\WinPython-64bit-3.5.2.1Qt5\python-3.5.2.amd64\lib\json\__init__.py", line 268, in load
parse_constant=parse_constant, object_pairs_hook=object_pairs_hook, **kw)
File "C:\WinPython-64bit-3.5.2.1Qt5\python-3.5.2.amd64\lib\json\__init__.py", line 332, in loads
return cls(**kw).decode(s)
File "C:\WinPython-64bit-3.5.2.1Qt5\python-3.5.2.amd64\lib\json\decoder.py", line 339, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "C:\WinPython-64bit-3.5.2.1Qt5\python-3.5.2.amd64\lib\json\decoder.py", line 357, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0) |
Collaborator
|
We could set-up AppVeyor to test on Windows. I'll try to look at it next week at one point. |
Collaborator
Author
|
New fix, tests welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.