Skip to content

Remove installation to deprecated include path #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophfroehlich wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove installation to deprecated include path #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46e947c
Remove deprecated include path
christophfroehlich Mar 10, 2026
5f4dd2b
Revert format change
christophfroehlich Mar 10, 2026
cb5744e
Merge branch 'main' into cleanup/deprecation
christophfroehlich Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ generate_parameter_module(
**src/turtlesim.cpp**
```c++
#include <rclcpp/rclcpp.hpp>
#include <turtlesim/turtlesim_parameters.hpp> // you can also use the deprecated #include "turtlesim_parameters.hpp"
#include <turtlesim/turtlesim_parameters.hpp>

int main(int argc, char * argv[])
{
Expand Down
15 changes: 0 additions & 15 deletions generate_parameter_library/cmake/generate_parameter_library.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ macro(generate_parameter_library LIB_NAME YAML_FILE)

# Copy the header file into the include directory
file(COPY ${IN_VALIDATE_HEADER} DESTINATION ${LIB_INCLUDE_DIR})
# necessary so that #include <param_file.hpp> can be used in the local package (deprecated)
file(COPY ${IN_VALIDATE_HEADER} DESTINATION ${CMAKE_CURRENT_BINARY_DIR}/include)
endif()

# Set the yaml file parameter to be relative to the current source dir
Expand All @@ -68,19 +66,6 @@ macro(generate_parameter_library LIB_NAME YAML_FILE)
"Running `${generate_parameter_library_cpp_BIN} ${PARAM_HEADER_FILE} ${YAML_FILE_PATH} ${VALIDATE_HEADER_FILENAME}`"
VERBATIM
)
# necessary so that #include <param_file.hpp> can be used in the local package (deprecated)
set(LOCAL_PARAM_HEADER_FILE ${CMAKE_CURRENT_BINARY_DIR}/include/${LIB_NAME}.hpp)
set(LOCAL_PARAM_HEADER_PRAGMA_WARNING_FILE ${CMAKE_CURRENT_BINARY_DIR}/${LIB_NAME}_pragma_warning)
file(WRITE ${LOCAL_PARAM_HEADER_PRAGMA_WARNING_FILE}
"#pragma message(\"#include \\\"${LIB_NAME}.hpp\\\" is deprecated. Use #include <${PROJECT_NAME}/${LIB_NAME}.hpp> instead.\")\n")
add_custom_command(
OUTPUT ${LOCAL_PARAM_HEADER_FILE}
COMMAND ${CMAKE_COMMAND} -E cat ${LOCAL_PARAM_HEADER_PRAGMA_WARNING_FILE} ${PARAM_HEADER_FILE} > ${LOCAL_PARAM_HEADER_FILE}
DEPENDS ${PARAM_HEADER_FILE}
COMMENT
"Creating deprecated header file ${LOCAL_PARAM_HEADER_FILE}"
VERBATIM
)

# Create the library target
add_library(${LIB_NAME} INTERFACE ${PARAM_HEADER_FILE} ${VALIDATE_HEADER} ${LOCAL_PARAM_HEADER_FILE})
Expand Down
Loading