Fix nested mapped parameters map#306
Merged
christophfroehlich merged 13 commits intoPickNikRobotics:mainfrom Mar 14, 2026
Merged
Fix nested mapped parameters map#306christophfroehlich merged 13 commits intoPickNikRobotics:mainfrom
christophfroehlich merged 13 commits intoPickNikRobotics:mainfrom
Conversation
NickLaurenson-Visionick
force-pushed
the
fix/278
branch
3 times, most recently
from
1664af6 to
7fef7cf
Compare
NickLaurenson-Visionick
changed the title
christophfroehlich
requested changes
Jan 27, 2026
Collaborator
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Can you please have a look at the failing CI jobs?
Contributor
Author
|
Yes sure I will take a look in the next day |
added 3 commits
February 23, 2026 15:06
Previously, the generator assumed that mapped parameter keys (the arrays used for __map_ segments) were either at the root level or provided as bare names. This caused the generator to fail or produce incorrect paths when dynamic parameters were nested inside deep struct hierarchies where the "key" array was defined in a parent scope. fix PickNikRobotics#278
- group test that test setup_up function via parametrization - add some config file file dor nested parameter map - add a test about get_dynamic_mapped_parameter
NickLaurenson-Visionick
force-pushed
the
fix/278
branch
from
7fef7cf to
0a39b4d
Compare
Contributor
Author
|
I update the branch, and fix the compilation locally (via ci_industrial tool). @christophfroehlich can you see it it fix the ci too? |
Contributor
Author
|
Fix the style issue, everything should be fine now. |
Contributor
Author
|
@christophfroehlich would it be possible to have a review? |
christophfroehlich
requested changes
Mar 10, 2026
Collaborator
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
CI is happy now, the changes look good as far as I can tell.
Can you please also update https://github.com/PickNikRobotics/generate_parameter_library?tab=readme-ov-file#mapped-parameters with the possible variants?
generate_parameter_library_py/generate_parameter_library_py/test/YAML_parse_error_test.py
Outdated
Show resolved
Hide resolved
generate_parameter_library_py/generate_parameter_library_py/test/mapped_parameter_test.py
Outdated
Show resolved
Hide resolved
christophfroehlich
added
the
backport-humble
…st/mapped_parameter_test.py Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
generate_parameter_library_py/generate_parameter_library_py/test/YAML_parse_error_test.py
Outdated
Show resolved
Hide resolved
christophfroehlich
approved these changes
Mar 14, 2026
Collaborator
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Thanks for the iterations. I tried it out on my own now, and added some test output to the examples.
christophfroehlich
added a commit
that referenced
this pull request
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this PR aim to fix #278.
As mention in the issue, the root caused came from
get_dynamic_mapped_parameter_names, not return the full nested path:if the the field to be mapped was
.nested_field.final_field, the function returnfinal_fieldcausing error in the generated code.Regarding the test, I wrote some basic one, let me know if need to do something else