Migrate tl expected to libexpected dev#159
Migrate tl expected to libexpected dev#159christophfroehlich merged 3 commits intoPickNikRobotics:mainfrom
Conversation
Signed-off-by: Tamaki Nishino <otamachan@gmail.com>
|
I tested RSL_BUILD_TESTING=ON on my fork (otamachan#1) and confirmed that the following changes from #155/#156 are needed:
I can squash these fixes into #159, or we can merge #156 first and rebase #159 on top of it. Which do you prefer? |
|
Can you please leave a review in #156? Then I merge it and you can merge master into your branch. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 98.65% 98.63% -0.02%
==========================================
Files 11 12 +1
Lines 223 220 -3
Branches 0 22 +22
==========================================
- Hits 220 217 -3
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the reviews and support on PickNikRobotics/generate_parameter_library#311. It looks like we're close to resolving it! |
Switch dependency from ROS tl_expected to system libexpected-dev to resolve overlapping header conflicts .
See PickNikRobotics/generate_parameter_library#311