Skip to content

Migrate tl expected to libexpected dev#159

Merged
christophfroehlich merged 3 commits intoPickNikRobotics:mainfrom
otamachan:migrate-tl-expected-to-libexpected-dev
Mar 12, 2026
Merged

Migrate tl expected to libexpected dev#159
christophfroehlich merged 3 commits intoPickNikRobotics:mainfrom
otamachan:migrate-tl-expected-to-libexpected-dev

Conversation

@otamachan
Copy link
Contributor

Switch dependency from ROS tl_expected to system libexpected-dev to resolve overlapping header conflicts .

See PickNikRobotics/generate_parameter_library#311

@otamachan otamachan marked this pull request as ready for review March 7, 2026 09:29
Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically #155 + #156?
Could you maybe have a look at #156, does that make sense to harden the fmt output just to satisfy tests?

@otamachan
Copy link
Contributor Author

I tested RSL_BUILD_TESTING=ON on my fork (otamachan#1) and confirmed that the following changes from #155/#156 are needed:

  • range-v3 in Windows CI pixi dependencies (test dependency)
  • stringify helper for consistent fmt output across platforms (RHEL test failures: 1.0 vs 1)
  • DISCOVERY_MODE PRE_TEST for catch_discover_tests (Windows DLL not found at build-time discovery)

I can squash these fixes into #159, or we can merge #156 first and rebase #159 on top of it. Which do you prefer?

@christophfroehlich
Copy link
Collaborator

Can you please leave a review in #156? Then I merge it and you can merge master into your branch.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.63%. Comparing base (e93c545) to head (664ef11).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   98.65%   98.63%   -0.02%     
==========================================
  Files          11       12       +1     
  Lines         223      220       -3     
  Branches        0       22      +22     
==========================================
- Hits          220      217       -3     
  Misses          3        3              
Flag Coverage Δ
humble ?
rolling 98.63% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's basically a duplicate of mine, but kudos for you that you brought the topic up!

@otamachan
Copy link
Contributor Author

otamachan commented Mar 11, 2026

Thanks for the reviews and support on PickNikRobotics/generate_parameter_library#311. It looks like we're close to resolving it!

@christophfroehlich christophfroehlich merged commit d79190e into PickNikRobotics:main Mar 12, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants