Debouncing #47
Open
Debouncing #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thibaultzanini
commented
Apr 15, 2025
thibaultzanini
commented
- Add debounced interaction management to Target
- Add debouncing functionality to Button component
thibaultzanini
commented
Apr 15, 2025
| } | ||
| } | ||
|
|
||
| _updateActionDebounceRegistration() { |
Collaborator
Author
There was a problem hiding this comment.
@marchant if you come up with a better name
| * @type {Map<string, number>} | ||
| * @private | ||
| */ | ||
| __debouncedInteractionThresholds: { value: null }, |
Collaborator
Author
There was a problem hiding this comment.
@marchant if you come up with a better name
| this._debouncedInteractionTimestamps.delete(interactionKey); | ||
| } | ||
|
|
||
| shouldPreventInteraction(interactionKey) { |
Collaborator
Author
There was a problem hiding this comment.
@marchant if you come up with a better name
| this.active = false; | ||
| this.dispatchActionEvent(); | ||
|
|
||
| if (!this.shouldPreventInteraction("action")) { |
Collaborator
Author
There was a problem hiding this comment.
@marchant I tried to add it to the press composer and the key composers and it worked fine only when the source was the same composer.
Meaning, an interaction from the press composer and the key composer during the debouncing window will cause 2 action events. So, I added the logic to Target and it's managed by the button itself. I also have a version working for the press composer and the key composer but that would be for another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.