Attempt to fix issues with BuildLimitGroup#2285
Open
Coronia wants to merge 2 commits into
Open
Conversation
Coronia
added
❓Phobos bug
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Contributor
Author
|
so far no issue has occured in testing, but I'm not sure whether they're all resolved. Would require some more test and review |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously BuildLimitGroup has several issues. E.g. Techno is still buildable when it's reaching the limit but stuck at 50% building progress under certain conditions. This is an attempt to fix some of the issues, which refractor the code of BuildLimitGroup on upgrade to make it work independently from other techno