Skip to content

inno_spectra#1392

Merged
trife merged 19 commits intomainfrom
inno_spectra
Mar 11, 2026
Merged

inno_spectra#1392
trife merged 19 commits intomainfrom
inno_spectra

Conversation

@chaneylc
Copy link
Copy Markdown
Member

@chaneylc chaneylc commented Feb 2, 2026

Description

Inno Spectra Nano Trait

Potential improvements:
saving coefficient / reference matrix after first load to speed up subsequent connections

Change Type

  • ADDITION (non-breaking change that adds functionality)
  • CHANGE (fix or feature that alters existing functionality)
  • FIX (non-breaking change that resolves an issue)
  • OTHER (use only for changes like tooling, build system, CI, docs, etc.)

Release Note

New Innospectra trait format

Copy link
Copy Markdown
Member

@trife trife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It seems that it's possible to scan using the physical button but the data isn't transferred until the software scan button is pressed. I think this is counter to how Prospector operated where the physical button would also initiate and save a scan.
  • There are issues with the layout when a device is disconnected- padding/spacing is off and the config button is still displayed. These issues are resolved by going back to Collect.
  • Is this implementation device specific or will it work for other devices from InnoSpectra? Regardless, nano is not used in any of InnoSpectra's branding material, so if it's device specific we should refer to it by the model name (InnoSpectra NIR-S-G1) and if it's manufacturer specific we should refer to it by the company name (InnoSpectra -- there are a few places where a space is included)
  • Include device battery level and firmware version in the config dialog
  • Trait scroller doesn't show that data has been saved after a successful scan
  • This is one for conversation: should scan numbers be dynamic or static? From a user perspective, if I scan something 5 times and then delete scan 2, having the remaining scans immediately renumber might be confusing
  • I won't be able to immediately test this, but Innospectras have a calibrated range of wavelengths that they collect, i.e. the headers are not equal between devices (though they are close). How would collecting data from two different models in the same experiment impact the data organization and export?

@chaneylc
Copy link
Copy Markdown
Member Author

I won't be able to immediately test this, but Innospectras have a calibrated range of wavelengths that they collect, i.e. the headers are not equal between devices (though they are close). How would collecting data from two different models in the same experiment impact the data organization and export?

I previously wrote an algorithm to handle this, it would manage one file for devices that capture values across different wavelengths, filling in missing data with 0.0. We ultimately decided against this for now, and currently this should be done by using two different traits; each device having its own spectral file on export. I could reintegrate this algorithm or have a similar approach where the file name changes depending on the device identifiers to only require one trait, in that case there would be one-to-many traits to spectral files (per device).

@chaneylc
Copy link
Copy Markdown
Member Author

Is this implementation device specific or will it work for other devices from InnoSpectra? Regardless, nano is not used in any of InnoSpectra's branding material, so if it's device specific we should refer to it by the model name (InnoSpectra NIR-S-G1) and if it's manufacturer specific we should refer to it by the company name (InnoSpectra -- there are a few places where a space is included)

If it has bluetooth capabilities and works with their SDK it should work here. They refer to their devices as Nano in their SDK, which is why I used that. I removed Nano from any user-facing string to avoid confusion.

@chaneylc
Copy link
Copy Markdown
Member Author

This is one for conversation: should scan numbers be dynamic or static? From a user perspective, if I scan something 5 times and then delete scan 2, having the remaining scans immediately renumber might be confusing

I agree this could be confusing.

chaneylc and others added 5 commits February 23, 2026 10:44
updated spectral line graph y-axis formatting
# Conflicts:
#	app/src/main/java/com/fieldbook/tracker/activities/CollectActivity.java
#	app/src/main/java/com/fieldbook/tracker/traits/formats/Formats.kt
#	app/src/main/res/values/strings.xml
@trife trife merged commit fdc8326 into main Mar 11, 2026
@trife trife deleted the inno_spectra branch March 11, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants