Skip to content

[PER-10415] New date editing full screen#1009

Draft
aasandei-vsp wants to merge 7 commits into
PER-10643-edtf-validationfrom
PER-10415-new-date-editing-full-screen
Draft

[PER-10415] New date editing full screen#1009
aasandei-vsp wants to merge 7 commits into
PER-10643-edtf-validationfrom
PER-10415-new-date-editing-full-screen

Conversation

@aasandei-vsp

@aasandei-vsp aasandei-vsp commented May 1, 2026

Copy link
Copy Markdown
Contributor

Warning

This functionality is hidden under the edtf-date flag. Enable it only for testing — it must stay OFF in production.

Manual test cases — EDTF date in the full-screen record view (file-viewer)

Setup (run once)

  1. Log in or create a new account.
  2. Upload two files.
  3. Click a file to open it in full-screen view.
    Expected: The full-screen viewer opens with a metadata panel (name, description, Date, Uploaded, Size, Type).

Flag ON — EDTF date appears

  1. Turn the edtf-date flag ON.
  2. Open a file in full-screen view.
    Expected: The Date area shows the EDTF date control (clickable, opens a dropdown).
    Expected: No legacy plain "Date" text field is shown.

Flag OFF — legacy date appears

  1. Turn the edtf-date flag OFF.
  2. Open a file in full-screen view.
    Expected: The metadata table shows a legacy "Date" row with the inline date editor.
    Expected: The EDTF dropdown/modal control does not appear.

Modify the date from the dropdown (flag ON)

  1. Open a file in full-screen view.
  2. Click the Date control.
    Expected: The date dropdown opens.
  3. Enter April 12, 1985.
  4. Click Save.
    Expected: The Date area shows "April 12, 1985" with no error banner.

Modify the date from the modal (flag ON)

  1. Click the Date control.
  2. Click "More options".
    Expected: The edit date/time modal opens with a Start date card.
  3. Enter June 15, 1990.
  4. Click Save.
    Expected: The Date area updates to "June 15, 1990".

Cancel in the modal (flag ON)

  1. Click the Date control.
  2. Click "More options".
  3. Change the date to a new value.
  4. Click Cancel.
    Expected: The modal closes and the Date area still shows the previously saved value.

Persistence after refresh (flag ON)

  1. Set the date to April 12, 1985 and save.
    Expected: The Date area shows "April 12, 1985".
  2. Refresh the browser page.
    Expected: The full-screen view shows "April 12, 1985".

Persistence across left/right navigation (flag ON)

  1. Open the first file in full-screen view.
  2. Set its date to April 12, 1985 and save.
  3. Click the right chevron (›).
    Expected: The next file shows its own date or the empty state, not "April 12, 1985".
  4. Set this file's date to June 15, 1990 and save.
  5. Click the left chevron (‹).
    Expected: The first file shows "April 12, 1985".
  6. Click the right chevron (›).
    Expected: The second file shows "June 15, 1990".

Date shows in the sidebar after closing full-screen (flag ON)

  1. Set the date to April 12, 1985 and save.
  2. Click "Back".
    Expected: The full-screen view closes and the file list appears.
  3. Select the same file.
    Expected: The sidebar's Date section shows "April 12, 1985".

Shared item — date is disabled (flag ON)

  1. Share a file with another account using view-only (Viewer) access.
  2. Log in as the recipient account.
  3. Open the shared file in full-screen view.
    Expected: The Date area shows the saved date (or empty state).
  4. Click the Date control.
    Expected: Nothing happens — the date is disabled and the dropdown/modal does not open.

@aasandei-vsp aasandei-vsp self-assigned this May 1, 2026
@aasandei-vsp aasandei-vsp marked this pull request as draft May 1, 2026 12:33
@codecov

codecov Bot commented May 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.76%. Comparing base (1c74479) to head (b3401aa).

Files with missing lines Patch % Lines
...er/components/file-viewer/file-viewer.component.ts 68.00% 8 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           PER-10643-edtf-validation    #1009   +/-   ##
==========================================================
  Coverage                      51.76%   51.76%           
==========================================================
  Files                            354      354           
  Lines                          12109    12132   +23     
  Branches                        2175     2178    +3     
==========================================================
+ Hits                            6268     6280   +12     
- Misses                          5615     5626   +11     
  Partials                         226      226           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasandei-vsp aasandei-vsp force-pushed the PER-10415-new-date-editing-full-screen branch from f2608ad to c37d8a3 Compare May 6, 2026 13:56
@aasandei-vsp aasandei-vsp marked this pull request as ready for review May 6, 2026 13:57
@aasandei-vsp aasandei-vsp changed the title [WIP] Per 10415 new date editing full screen [PER-10415] [BLOCKED] New date editing full screen May 6, 2026
@aasandei-vsp aasandei-vsp marked this pull request as draft June 8, 2026 06:55
Extract the detault qualifiers into a shared constant.
Add a display update in the sidebar when the modal saves a new date.

Issue: PER-10642
Left-pad single-digit month and day values with zero instead of
X-padding them, since a single 1-9 digit can only be a complete value
('5' -> '05', no longer '5X'). Require a complete date whenever a time
is provided and surface a dedicated friendly error message for that
case. Add a generic getSegmentError helper that the datepicker and
timepicker inputs use to build their inline field error messages
(invalid characters and out-of-range checks, skipped while the value
is still being typed).

Issue: PER-10643
Instead of silently rejecting invalid input, the year, month and day
segments now emit whatever the user typed and surface a per-field
error message below the input (invalid characters, out-of-range month
or day). The day is re-validated when the month changes, and picking
a date from the calendar clears all errors. The error styling lives
in new shared input-error-state and input-error-message mixins.

Issue: PER-10643
Instead of silently rejecting invalid input, the hours, minutes and
seconds segments now emit whatever the user typed and surface a
per-field error message below the input. The hour is re-validated
when the AM/PM/24H format changes.

Issue: PER-10643
…splay dates

Add new getStelaFolderVOs method to retrieve updated folder information
from the v2 API endpoint. This method handles both single and multiple
folder requests with optional share token support.

Add updateStelaFolder method to update folder date ranges by combining
start and end dates into EDTF interval format before sending to the server.

These changes enable proper synchronization of folder date information
between the client and server when users edit date ranges in the UI.

ISSUE: PER-10475
@aasandei-vsp aasandei-vsp force-pushed the PER-10415-new-date-editing-full-screen branch from c37d8a3 to 5560ea0 Compare June 17, 2026 08:48
@aasandei-vsp aasandei-vsp changed the base branch from main to PER-10642-create-edtf-date-modal-component June 17, 2026 08:48
@aasandei-vsp aasandei-vsp changed the title [PER-10415] [BLOCKED] New date editing full screen [PER-10415] New date editing full screen Jun 17, 2026
@aasandei-vsp aasandei-vsp changed the base branch from PER-10642-create-edtf-date-modal-component to PER-10643-edtf-validation June 17, 2026 08:49
Show the EDTF picker only when the flag is on, else the legacy date
field. Port the sidebar fixes: cached displayTimeObject, re-sync after
save, and a tracked modal subscription.

Issue: PER-10641
@aasandei-vsp aasandei-vsp force-pushed the PER-10415-new-date-editing-full-screen branch from 5560ea0 to b3401aa Compare June 17, 2026 11:26
@aasandei-vsp aasandei-vsp force-pushed the PER-10643-edtf-validation branch from 1c74479 to fe7dd07 Compare June 17, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant