[PER-10415] New date editing full screen#1009
Draft
aasandei-vsp wants to merge 7 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PER-10643-edtf-validation #1009 +/- ##
==========================================================
Coverage 51.76% 51.76%
==========================================================
Files 354 354
Lines 12109 12132 +23
Branches 2175 2178 +3
==========================================================
+ Hits 6268 6280 +12
- Misses 5615 5626 +11
Partials 226 226 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f2608ad to
c37d8a3
Compare
Extract the detault qualifiers into a shared constant. Add a display update in the sidebar when the modal saves a new date. Issue: PER-10642
Left-pad single-digit month and day values with zero instead of
X-padding them, since a single 1-9 digit can only be a complete value
('5' -> '05', no longer '5X'). Require a complete date whenever a time
is provided and surface a dedicated friendly error message for that
case. Add a generic getSegmentError helper that the datepicker and
timepicker inputs use to build their inline field error messages
(invalid characters and out-of-range checks, skipped while the value
is still being typed).
Issue: PER-10643
Instead of silently rejecting invalid input, the year, month and day segments now emit whatever the user typed and surface a per-field error message below the input (invalid characters, out-of-range month or day). The day is re-validated when the month changes, and picking a date from the calendar clears all errors. The error styling lives in new shared input-error-state and input-error-message mixins. Issue: PER-10643
Instead of silently rejecting invalid input, the hours, minutes and seconds segments now emit whatever the user typed and surface a per-field error message below the input. The hour is re-validated when the AM/PM/24H format changes. Issue: PER-10643
…splay dates Add new getStelaFolderVOs method to retrieve updated folder information from the v2 API endpoint. This method handles both single and multiple folder requests with optional share token support. Add updateStelaFolder method to update folder date ranges by combining start and end dates into EDTF interval format before sending to the server. These changes enable proper synchronization of folder date information between the client and server when users edit date ranges in the UI. ISSUE: PER-10475
Issue: PER-10415
c37d8a3 to
5560ea0
Compare
Show the EDTF picker only when the flag is on, else the legacy date field. Port the sidebar fixes: cached displayTimeObject, re-sync after save, and a tracked modal subscription. Issue: PER-10641
5560ea0 to
b3401aa
Compare
1c74479 to
fe7dd07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This functionality is hidden under the
edtf-dateflag. Enable it only for testing — it must stay OFF in production.Manual test cases — EDTF date in the full-screen record view (file-viewer)
Setup (run once)
Expected: The full-screen viewer opens with a metadata panel (name, description, Date, Uploaded, Size, Type).
Flag ON — EDTF date appears
edtf-dateflag ON.Expected: The Date area shows the EDTF date control (clickable, opens a dropdown).
Expected: No legacy plain "Date" text field is shown.
Flag OFF — legacy date appears
edtf-dateflag OFF.Expected: The metadata table shows a legacy "Date" row with the inline date editor.
Expected: The EDTF dropdown/modal control does not appear.
Modify the date from the dropdown (flag ON)
Expected: The date dropdown opens.
Expected: The Date area shows "April 12, 1985" with no error banner.
Modify the date from the modal (flag ON)
Expected: The edit date/time modal opens with a Start date card.
Expected: The Date area updates to "June 15, 1990".
Cancel in the modal (flag ON)
Expected: The modal closes and the Date area still shows the previously saved value.
Persistence after refresh (flag ON)
Expected: The Date area shows "April 12, 1985".
Expected: The full-screen view shows "April 12, 1985".
Persistence across left/right navigation (flag ON)
Expected: The next file shows its own date or the empty state, not "April 12, 1985".
Expected: The first file shows "April 12, 1985".
Expected: The second file shows "June 15, 1990".
Date shows in the sidebar after closing full-screen (flag ON)
Expected: The full-screen view closes and the file list appears.
Expected: The sidebar's Date section shows "April 12, 1985".
Shared item — date is disabled (flag ON)
Expected: The Date area shows the saved date (or empty state).
Expected: Nothing happens — the date is disabled and the dropdown/modal does not open.