Use new location metadata fields by slifty · Pull Request #1002 · PermanentOrg/web-app

slifty · 2026-04-27T19:37:35Z

This PR modifies the web app to use the new location metadata fields for both reading and writing data.

Resolves #1001

codecov · 2026-04-27T19:39:08Z

Codecov Report

❌ Patch coverage is 89.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.47%. Comparing base (2b811f1) to head (fcc3fd0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
src/app/core/services/edit/edit.service.ts	57.14%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
+ Coverage   50.03%   50.47%   +0.44%     
==========================================
  Files         348      348              
  Lines       11497    11543      +46     
  Branches     1974     1995      +21     
==========================================
+ Hits         5752     5826      +74     
+ Misses       5559     5530      -29     
- Partials      186      187       +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Updates the Angular web app’s location handling to support newly introduced location metadata fields (e.g., name/sublocation/city and role/precision/raw metadata), aligning the UI formatting and client-side models with the updated location schema.

Changes:

Extend location DTO/model types with new metadata fields (name, sublocation, city, altitudeMeters, role/precision/raw metadata).
Map Stela location fields into the app’s LocnVOData shape, including renaming role/precision/raw to locationRole/locationPrecision/rawMetadata.
Prefer new location fields when rendering location display strings and when creating locations from Google Places.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
`src/app/shared/services/api/record.repo.ts`	Adds new Stela location fields and maps role/precision/raw into the app’s renamed metadata fields during conversion.
`src/app/shared/pipes/pr-location.pipe.ts`	Updates display formatting to prefer `sublocation`, `city`, and `name` when present.
`src/app/models/locn-vo.ts`	Extends `LocnVOData` with new location metadata fields used across the app.
`src/app/file-browser/components/location-picker/location-picker.component.ts`	Populates `sublocation`, `city`, and `name` when creating a location from a selected Google Place.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cecilia-donnelly

I don't see anything obviously off here! I have some questions, likely answered by your partner PRs to this one, but wanted to ask them right away.

cecilia-donnelly · 2026-04-29T19:29:48Z

-			return component
-				? component[getShortName ? 'short_name' : 'long_name']
-				: null;
+			return component ? component.long_name : null;


What was the short name?

@slifty is going to figure out if we want to keep that after all.

The idea is that short vs long name isn't part of the new location specification, and so we just use the long name now because it's the only thing that will exist in the future.

Short name might have been "CA" when long name was "California"

aasandei-vsp

LGTM, small observations.

github-actions · 2026-05-05T19:14:00Z

QA Instructions

QA Testing Instructions for PR: "Use new location metadata fields"

Summary

This PR updates various components and services in the web app to use new location metadata fields (LocnVO) for managing record and folder location data. The changes involve modifying the EditService, updating relevant API calls (e.g., updateStelaRecord and updateStelaFolder), and adding/adjusting associated tests. Changes also include the implementation of new tests for the LocationPickerComponent.

Test Environment Setup

Ensure you are on the branch related to this PR: use-new-location-metadata-fields.
Pull the latest changes and ensure all dependencies are installed by running:
```
git pull
npm install
```
Start the development server using:
```
npm run start
```
Confirm that the backend services are running and configured to support the updated Stela endpoints for handling the new location metadata fields.

Test Scenarios

Verify Updates to Records with New LocnVO Field
- Steps:
  1. Open the web app and navigate to a page where you can manage a record.
  2. Modify the location metadata (LocnVO) of the record using the Location Picker.
  3. Save the changes.
  4. Check the network requests and confirm that the API call updateStelaRecord was made with correct parameters, including the location key in the metadata payload.
- Expected Result:
  - The updated location metadata (e.g., latitude, longitude, or address) should correctly reflect on the UI after saving.
  - The API call to updateStelaRecord should include LocnVO in its parameters.
Verify Updates to Folders with New LocnVO Field
- Steps:
  1. Navigate to a folder whose location metadata can be edited.
  2. Modify the location data (LocnVO) of the folder using the Location Picker.
  3. Save the changes.
  4. Verify via network requests that the updateStelaFolder API was called with the correct payload, including the location key in the metadata update.
- Expected Result:
  - The folder's location details should be updated and displayed correctly in the UI.
  - The network request should include the location as part of its payload.
Validate Location Picker Component Behavior
- Steps:
  1. Open the LocationPickerComponent in the UI.
  2. Enter a location in the input field and verify that suggestions are displayed.
  3. Select a location from the suggestions.
  4. Confirm that the location preview updates correctly with the selected place details (e.g., address and map location).
- Expected Result:
  - The suggestions should show based on the user input.
  - Selecting a location should populate the address and map fields in the UI accurately.
Verify Component-Level Integration with LocationPickerComponent
- Steps:
  1. Navigate to a sample record or folder page where the LocationPickerComponent is used.
  2. Perform location updates via the location picker.
  3. Save the changes and refresh the page.
  - Observe if the changes persist and are displayed correctly.
- Expected Result:
  - The updated location metadata should persist in the backend and match across page loads.
Validate Test Coverage
- Steps:
  1. Run unit tests for the project:
```
npm run test
```
  2. Verify updated test files:
    - edit.service.spec.ts
    - location-picker.component.spec.ts
  - Confirm all test cases pass without errors.
- Expected Result:
  - All test cases in the modified specs pass.
  - No regressions or new errors are introduced.

Regression Risks

EditService Core Functionality:
- Edits and updates for records and folders that do not involve location metadata (LocnVO) should still function as expected.
- Watch for potential side effects in methods like updateItems in edit.service.ts.
Legacy Field Dependencies:
- Ensure existing location-related functionality (previously tied to other metadata fields) continues to work correctly.
- Scenarios involving older location fields should gracefully degrade if they are no longer supported.
Integration with Backend:
- Any mismatches between frontend and backend in the payload structure for location metadata updates could cause API call failures, so validate API request payloads thoroughly.

Things to Watch For

Validation of Location Metadata Entries:
- Ensure that invalid or incomplete location data (e.g., missing latitude/longitude) is properly handled on the frontend, and users are prompted accordingly without errors.
Map Rendering Issues:
- While testing the LocationPickerComponent, verify correct map rendering for edge cases:
  - Locations with minimal metadata (e.g., missing coordinates).
  - International addresses with non-Western characters.
  - Rapid switching between different autocomplete suggestions.
Performance of Bulk Updates:
- Confirm the updateItems method handles larger batches of records/folders without timing out or exhibiting performance issues.
- Monitor the API calls for compliance with new expected payload formats.

Notes

The changes in this PR are primarily backend-dependent. Any issues with the updated Stela endpoints might manifest as errors in saving location metadata. Ensure to closely monitor API responses.
Validate changes in major browsers (Chrome, Firefox, Safari, Edge) to ensure compatibility.
Keep logs enabled during testing to track errors or unexpected behavior for debugging purposes.

Generated by QA Instructions Action

slifty · 2026-05-05T20:04:27Z

In my own testing: I'd like to wait until the stela endpoints for location creation are live before moving the frontend to use the new properties.

omnignorant

Not 100% sure what I am testing or what the success condition should be, but I did my best to suss it out of the QA guide. The gist seems to be "does a location properly save using the current picker UI"

Location editing seems to work inconsistently. In the screen capture attached here, I seem to have determined the following:

location seems to save on initial selection
for records without existing location data, the changed metadata persists after a refresh;
for records with existing location data, the metadata does not persist;
location metadata in profile, both general and milestone persists.

Screen.Recording.2026-05-08.at.4.50.36.PM.mov

slifty · 2026-05-11T14:30:45Z

@omnignorant sorry for the confusion -- I pulled this off of the QA pile since we need to do some additional changes for everything to work as expected!

slifty · 2026-06-04T19:01:19Z

Before we merge this I want to re-check to ensure that records with legacy location metadata work as expected.

aasandei-vsp

Left a few comments, but overall looks good.

Checked all location instances that I know of(manual testing):

Sidebar
Archive settings --> Milestones --> Location
Group info --> Location established
Gallery --> current archive --> info

The backend is changing which location metadata fields to store and we need to use those fields. Issue #1001 Use new location metadata fields

Stela now supports editing location metadata using the modern location fields. This change helps us migrate from the use PHP and the old model for locations. Issue #1001 Use new location metadata fields

Copilot AI review requested due to automatic review settings April 27, 2026 19:37

Copilot AI reviewed Apr 27, 2026

View reviewed changes

slifty force-pushed the 1001-use-new-location-fields branch 2 times, most recently from 8aacc88 to 0ef7893 Compare April 28, 2026 19:54

slifty requested a review from Copilot April 28, 2026 20:01

Copilot started reviewing on behalf of slifty April 28, 2026 20:01 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

slifty force-pushed the 1001-use-new-location-fields branch from 0ef7893 to 75feaaa Compare April 29, 2026 19:11

cecilia-donnelly self-requested a review April 29, 2026 19:15

slifty force-pushed the 1001-use-new-location-fields branch from 75feaaa to e18814e Compare April 29, 2026 19:21

cecilia-donnelly reviewed Apr 29, 2026

View reviewed changes

cecilia-donnelly requested a review from aasandei-vsp April 29, 2026 20:05

slifty force-pushed the 1001-use-new-location-fields branch from e18814e to 07ca375 Compare April 29, 2026 20:13

aasandei-vsp approved these changes May 5, 2026

View reviewed changes

Comment thread src/app/shared/services/api/record.repo.ts

Comment thread src/app/shared/services/api/record.repo.ts

slifty added the QA This issue is ready for QA / user acceptance testing label May 5, 2026

slifty requested a review from omnignorant May 5, 2026 19:13

slifty removed QA This issue is ready for QA / user acceptance testing labels May 5, 2026

omnignorant requested changes May 8, 2026

View reviewed changes

slifty force-pushed the 1001-use-new-location-fields branch 3 times, most recently from 5a36b6d to 143c687 Compare June 4, 2026 18:58

slifty requested a review from aasandei-vsp June 4, 2026 18:58

slifty force-pushed the 1001-use-new-location-fields branch from 143c687 to 3665fa9 Compare June 4, 2026 18:58

aasandei-vsp approved these changes Jun 5, 2026

View reviewed changes

Comment thread src/app/shared/services/api/record.repo.ts

Comment thread src/app/shared/services/api/record.repo.ts

slifty added the QA This issue is ready for QA / user acceptance testing label Jun 15, 2026

slifty requested a review from omnignorant June 15, 2026 15:31

slifty added 2 commits June 15, 2026 11:46

Render new location metadata fields

950641d

The backend is changing which location metadata fields to store and we need to use those fields. Issue #1001 Use new location metadata fields

Use stela endpoints for folder and record location

fcc3fd0

Stela now supports editing location metadata using the modern location fields. This change helps us migrate from the use PHP and the old model for locations. Issue #1001 Use new location metadata fields

slifty force-pushed the 1001-use-new-location-fields branch from 3665fa9 to fcc3fd0 Compare June 15, 2026 15:46

Uh oh!

Conversation

slifty commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cecilia-donnelly left a comment

Choose a reason for hiding this comment

Uh oh!

cecilia-donnelly Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

cecilia-donnelly Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

slifty Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aasandei-vsp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

QA Instructions

QA Testing Instructions for PR: "Use new location metadata fields"

Summary

Test Environment Setup

Test Scenarios

Regression Risks

Things to Watch For

Notes

Uh oh!

slifty commented May 5, 2026

Uh oh!

omnignorant left a comment

Choose a reason for hiding this comment

Uh oh!

slifty commented May 11, 2026

Uh oh!

slifty commented Jun 4, 2026

Uh oh!

aasandei-vsp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

slifty commented Apr 27, 2026 •

edited

Loading

codecov Bot commented Apr 27, 2026 •

edited

Loading

github-actions Bot commented May 5, 2026 •

edited

Loading