Skip to content

Allow single IPTC keyword in metadata#778

Merged
liam-lloyd merged 1 commit into
mainfrom
noissue_allow_single_iptc_keyword
Jun 16, 2026
Merged

Allow single IPTC keyword in metadata#778
liam-lloyd merged 1 commit into
mainfrom
noissue_allow_single_iptc_keyword

Conversation

@liam-lloyd

Copy link
Copy Markdown
Member

Currently, we expect the IPTC:Keyword field in metadata files to be an object containing potentially multiple keywords. However, in some files it is simply a single keyword expressed as a string. This commit updates the metadata attacher lambda to handle that case.

@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.56%. Comparing base (cb47369) to head (f86140a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #778   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         109      109           
  Lines        2778     2778           
  Branches      463      464    +1     
=======================================
  Hits         2738     2738           
  Misses         36       36           
  Partials        4        4           
Flag Coverage Δ
api 98.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cecilia-donnelly cecilia-donnelly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to have such a long XML file as the fixture? (It seems like a simpler one would be less likely to break for some other reason unrelated to this specific test)

@liam-lloyd liam-lloyd force-pushed the noissue_allow_single_iptc_keyword branch from 5b2a8a0 to 2a06a3b Compare June 16, 2026 19:43
@liam-lloyd

Copy link
Copy Markdown
Member Author

Is there a reason to have such a long XML file as the fixture? (It seems like a simpler one would be less likely to break for some other reason unrelated to this specific test)

Most of the fixture metadata files used in this package are derived from a real one (from a test environment) in pursuit of authenticity, but it does make sense to a use a smaller one for specific test case like this.

Currently, we expect the IPTC:Keyword field in metadata files to be an
object containing potentially multiple keywords. However, in some files
it is simply a single keyword expressed as a string. This commit updates
the metadata attacher lambda to handle that case.
@liam-lloyd liam-lloyd force-pushed the noissue_allow_single_iptc_keyword branch from 2a06a3b to f86140a Compare June 16, 2026 20:56
@liam-lloyd liam-lloyd merged commit 12f9f32 into main Jun 16, 2026
35 checks passed
@liam-lloyd liam-lloyd deleted the noissue_allow_single_iptc_keyword branch June 16, 2026 21:04
@liam-lloyd liam-lloyd restored the noissue_allow_single_iptc_keyword branch June 23, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants