Allow single IPTC keyword in metadata#778
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 109 109
Lines 2778 2778
Branches 463 464 +1
=======================================
Hits 2738 2738
Misses 36 36
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cecilia-donnelly
left a comment
There was a problem hiding this comment.
Is there a reason to have such a long XML file as the fixture? (It seems like a simpler one would be less likely to break for some other reason unrelated to this specific test)
5b2a8a0 to
2a06a3b
Compare
Most of the fixture metadata files used in this package are derived from a real one (from a test environment) in pursuit of authenticity, but it does make sense to a use a smaller one for specific test case like this. |
Currently, we expect the IPTC:Keyword field in metadata files to be an object containing potentially multiple keywords. However, in some files it is simply a single keyword expressed as a string. This commit updates the metadata attacher lambda to handle that case.
2a06a3b to
f86140a
Compare
Currently, we expect the IPTC:Keyword field in metadata files to be an object containing potentially multiple keywords. However, in some files it is simply a single keyword expressed as a string. This commit updates the metadata attacher lambda to handle that case.