Conversation
slifty
force-pushed
the
45-fix-rclone-hang
branch
2 times, most recently
from
e74b0fb to
e1e89a0
Compare
There is an open PR in the upstream / ssh2 library related to properly closing SFTP channels when a `CHANNEL_EOF` message is received[1]. Unfortunately that PR has not yet been merged. Until that happens we need to handle the signal ourselves. Unfortunately this requires us to access "private" attributes (JavaScript doesn't support the concept of private attributes, so we are able to do this...). This is, of course a terrible and horrible idea and all of our tooling gets very upset about it. As a result I had to disable the tooling for the relevant line. Once the PR is merged in upstream we should upgrade to it and delete the contents of this commit. Issue #45 rclone hangs after completion [1] mscdex/ssh2#1111
slifty
force-pushed
the
45-fix-rclone-hang
branch
from
e1e89a0 to
0c2bad7
Compare
cecilia-donnelly
approved these changes
Feb 8, 2023
Member
cecilia-donnelly
left a comment
cecilia-donnelly
left a comment
There was a problem hiding this comment.
Thank you, @slifty! This all makes sense to me and I appreciate the detailed comment.
kfogel
approved these changes
Feb 9, 2023
Contributor
kfogel
left a comment
kfogel
left a comment
There was a problem hiding this comment.
Nicely done. This change is about as clean as it possibly can be, and it explains itself well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some fairly gnarly code to accommodate a bug in the upstream library that handles implementation of the ssh / sftp protocol's more inner workings.
There is already an upstream patch which unfortunately has not been merged yet. Once that is merged we can delete this local patch.
Resolves #45