Skip to content

Fix uri_for prefix behavior and ensure forward preserves app context;…#1752

Closed
Jkhall81 wants to merge 1 commit intoPerlDancer:mainfrom
Jkhall81:fix-uri-for-prefix
Closed

Fix uri_for prefix behavior and ensure forward preserves app context;…#1752
Jkhall81 wants to merge 1 commit intoPerlDancer:mainfrom
Jkhall81:fix-uri-for-prefix

Conversation

@Jkhall81
Copy link
Copy Markdown

@Jkhall81 Jkhall81 commented Dec 8, 2025

Related Issue #1747

This PR fixes a bug where uri_for (and uri_for_route) did not respect the application prefix when called inside a forwarded request.

What’s fixed

  • Forwarded requests now retain the app reference and uri_for_route callback.
  • uri_for correctly applies the app prefix in both normal and forwarded requests.

Added

  • New regression test: t/route_prefix_forward.t

This ensures that calling forward inside a prefixed app still generates proper prefixed URLs like /info/delete instead of /delete.

@xsawyerx
Copy link
Copy Markdown
Member

xsawyerx commented Jan 7, 2026

There is a lot of unrelated whitespace (new lines, end of line spacing, etc.) in this commit. Is it possible to clean them up please? It adds noise and makes it hard to review properly.

@Jkhall81
Copy link
Copy Markdown
Author

Jkhall81 commented Jan 7, 2026

Ah. yeah... Looks like format on save completely mangled both files. I'll just close this.

@Jkhall81 Jkhall81 closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants