Fix uri_for prefix behavior and ensure forward preserves app context;…#1752
Closed
Jkhall81 wants to merge 1 commit intoPerlDancer:mainfrom
Closed
Fix uri_for prefix behavior and ensure forward preserves app context;…#1752Jkhall81 wants to merge 1 commit intoPerlDancer:mainfrom
Jkhall81 wants to merge 1 commit intoPerlDancer:mainfrom
Conversation
Member
|
There is a lot of unrelated whitespace (new lines, end of line spacing, etc.) in this commit. Is it possible to clean them up please? It adds noise and makes it hard to review properly. |
Author
|
Ah. yeah... Looks like format on save completely mangled both files. I'll just close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue #1747
This PR fixes a bug where
uri_for(anduri_for_route) did not respect the application prefix when called inside a forwarded request.What’s fixed
uri_for_routecallback.uri_forcorrectly applies the app prefix in both normal and forwarded requests.Added
t/route_prefix_forward.tThis ensures that calling
forwardinside a prefixed app still generates proper prefixed URLs like/info/deleteinstead of/delete.