One go parsing

[ruz]

This pull request is a request for review and comments.

It fixes several issues reported earlier, but a few test start to fail. Could you please review failing tests and decide how to change tests and/or code?

[rjbs]

I believe that the failing test cases are test bugs, not code bugs in your changes.

Also, I loathe these tests. For example, this is terrible:

[
'"Name"',
...
]

The first argument there is fed to build a new address against which to compare the parsed one, so the double-quotes are redundant. It would be much better if the test values were tests for the results of the phrase, address, comment, as_string, and name methods. This would break tests with dumb extra quotes, but would make the meaning of the tests much easier. I'd actually like the tests to be more in the form:

$tests = {
  q{"Some Input" <string@example.com>} => [
    {
      as_string => ...defaults to "should be $input"...,
      phrase => "Some Input",
      address => 'string@example.com',
    }
  ],
  ...,
}

...maybe I'll do that after you're done, unless you build something from that Dominic Sayers corpus. ;)

[rjbs]

I pushed a few small changes, primarily to make it easier for me to skim test output.

[rjbs]

You wrote:

This pull request is a request for review and comments.

I reviewed, I think. What's left for this to be merged? Test fixes?

[ruz]

test fixes.