Test/fix erc20 harnesses #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for compose-diamonds pending review.Visit the deploys page to approve it
|
Contributor
|
@lumoswiz Great to see this. Once you feel your code is ready, please merge it. I trust you. |
Coverage Report
Last updated: Mon, 05 Jan 2026 18:13:17 GMT for commit |
Gas ReportNo gas usage changes detected between All functions maintain the same gas costs. ✅ Last updated: Mon, 05 Jan 2026 18:13:25 GMT for commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recent changes to the ERC-20 facets (splitting up of transfer/metadata) broke test harness imports, this PR fixes them.
In future PRs that approach the test refactor, we will be using harnesses sparingly in favour of storage util libs. I sought to make minimal changes here to get existing tests to compile.
Changes Made
ERC20MetadataFacetHarness- minimal harness with initialize() onlyERC20TransferFacetHarness- harness with mint() helperERC20BurnFacetHarnessto use ERC20TransferStorageERC20FacetERC20FacetChecklist
Before submitting this PR, please ensure:
Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions,
using fordirectives, orselfdestructCode follows Design Principles - Readable, uses diamond storage, favors composition over inheritance
Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)
Code is formatted with
forge fmtExisting tests pass - Run tests to be sure existing tests pass.
New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.
All tests pass - Run
forge testand ensure everything worksDocumentation updated - If applicable, update relevant documentation