Use Perastage SVG symbols for 2D layout fixtures with mesh fallback#1101
Merged
Use Perastage SVG symbols for 2D layout fixtures with mesh fallback#1101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
perastage_svg_symbol_builder(viewer3d/render/perastage_svg_symbol_builder.{h,cpp}) that loads Perastage SVG from a GDTF, converts fills and strokes toCommandBuffercommands, applies model offsets and computes symbol bounds.viewer3d/render/opaque_fixture_pass.cppto try building an SVG-backedSymbolDefinitionfirst and return it to the bottom-symbol cache when successful.viewer3d/CMakeLists.txtto keep explicit source ownership and module boundaries intact.Testing
tests/check_perastage_tree_modules.shand it passed.tests/check_no_configmanager_get_in_gui.shand it passed.Codex Task