Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the 3series workflow by restructuring solution file references, removing obsolete files and workflows, and modifying build scripts for version generation and output zipping.
- Updated solution file path in Pepperdash_Core.3Series.sln
- Removed legacy solution and multiple GitHub workflow files
- Adjusted build script logic in ZipBuildOutput.ps1 and GenerateVersionNumber.ps1 to accommodate new requirements
Reviewed Changes
Copilot reviewed 90 out of 90 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Pepperdash_Core.3Series.sln | Updated project path to align with new source directory structure |
| Pepperdash Core.slnold | Removed legacy solution file |
| .releaserc.json | Added release configuration using semantic-release plugins |
| .github/workflows/main.yml, docker.yml, add-issues-to-project.yml | Removed outdated workflows |
| .github/workflows/Essentials-builds-3series-caller.yml | Added new workflow for 3series builds |
| .github/scripts/ZipBuildOutput.ps1 | Updated file exclusion/inclusion patterns and renaming logic |
| .github/scripts/GenerateVersionNumber.ps1 | Added additional branch logging and handling for bugfix branches |
Comments suppressed due to low confidence (3)
.github/scripts/ZipBuildOutput.ps1:11
- The exclusion entry was changed from 'Newtonsoft.Json.Compact.dll' to 'Newtonsoft.Compact.Json.dll'. Please verify that the updated filename matches the actual DLL used in the project to avoid accidental inclusion.
$exclusions += "Newtonsoft.Compact.Json.dll"
Pepperdash_Core.3Series.sln:3
- The project file path has been updated from 'Pepperdash Core\PepperDash_Core.csproj' to 'src\PepperDash_Core.csproj'. Please confirm that this new path aligns with the intended source directory restructuring and that the build process is updated accordingly.
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PepperDash_Core", "src\PepperDash_Core.csproj", "{87E29B4C-569B-4368-A4ED-984AC1440C96}"
.github/scripts/GenerateVersionNumber.ps1:25
- [nitpick] A new branch pattern for pull requests has been introduced (and a similar pattern for bugfix branches in lines 51-54). Confirm that this versioning approach aligns with the project's versioning strategy and that the intended version string format is consistently applied across branch types.
'^refs\/pull\/*.' {
| Get-ChildItem -Path $destination | Where-Object { (($_.Extension -eq ".clz") -or ($_.Extension -eq ".cpz") -or ($_.Extension -eq ".cplz")) } | ForEach-Object { | ||
| # Replace the extensions with dll or xml and create an array | ||
| $filenames = @($($_ -replace "cpz|clz|cplz", "dll"), $($_ -replace "cpz|clz|cplz", "xml")) | ||
| Get-ChildItem -Path $destination | Where-Object { ($_.Extension -eq ".clz") -or ($_.Extension -eq ".cpz" -or ($_.Extension -eq ".cplz")) } | ForEach-Object { |
There was a problem hiding this comment.
[nitpick] The inclusion filter for output files now excludes JSON files and explicitly targets files with .dll, .clz, .cpz, and .cplz extensions. Ensure that this updated filter correctly captures all necessary build artifacts without inadvertently omitting important files.
| Get-ChildItem -Path $destination | Where-Object { ($_.Extension -eq ".clz") -or ($_.Extension -eq ".cpz" -or ($_.Extension -eq ".cplz")) } | ForEach-Object { | |
| Get-ChildItem -Path $destination | Where-Object { ($_.Extension -eq ".clz") -or ($_.Extension -eq ".cpz") -or ($_.Extension -eq ".cplz") -or ($_.Extension -eq ".dll") } | ForEach-Object { |
|
PR into wrong branch, closing. |
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the PepperDash_Core.nuspec file as part of the 3series workflow updates. The changes include an update to the authors element, a revision of the copyright year, and a modification to the file inclusion pattern.
Comments suppressed due to low confidence (2)
src/PepperDash_Core.nuspec:7
- [nitpick] Please verify that changing 'PepperDash Technologies' to 'PepperDash Technology' aligns with the intended branding for the project.
<authors>PepperDash Technology</authors>
src/PepperDash_Core.nuspec:18
- The file inclusion pattern has been changed to target only lib\net35. Confirm that excluding files for lib\net47 is intentional and that no required builds are omitted.
<file src=".\output\**" target="lib\net35"/>
No description provided.