feat: add circuitType property to IOPortConfig #1377
Merged
Conversation
- adds a config value that mutes the display when the screen is in the up position - screens will now mute/unmute based on their position if the config is set
Enhanced error and warning message generation to use monitor names when available, include counts, proper pluralization, and append "Offline" when issues are present. Avoided multiple enumerations by converting to lists. "Room Ok." is shown when no issues are detected.
…version in digital input devices
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for configuring the circuit type (Normally Open "NO" or Normally Closed "NC") for digital input devices, enabling automatic state inversion for NC circuits. This enhances flexibility when integrating different hardware configurations.
Changes:
- Added a
CircuitTypeproperty toIOPortConfigclass with a default value of "NO" - Updated
GenericDigitalInputDeviceto invert input state when CircuitType is set to "NC" - Updated
GenericVersiportDigitalInputDeviceto invert digital input state when CircuitType is set to "NC"
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/PepperDash.Essentials.Core/CrestronIO/IOPortConfig.cs | Added CircuitType property with JSON serialization to support NO/NC configuration |
| src/PepperDash.Essentials.Core/CrestronIO/GenericDigitalInputDevice.cs | Added invertState field and logic to conditionally invert input state based on circuit type |
| src/PepperDash.Essentials.Core/CrestronIO/GenericVersiportInputDevice.cs | Added invertState field and logic to conditionally invert input state based on circuit type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/PepperDash.Essentials.Core/CrestronIO/GenericVersiportInputDevice.cs
Show resolved
Hide resolved
src/PepperDash.Essentials.Core/CrestronIO/GenericDigitalInputDevice.cs
Outdated
Show resolved
Hide resolved
src/PepperDash.Essentials.Core/CrestronIO/GenericVersiportInputDevice.cs
Outdated
Show resolved
Hide resolved
src/PepperDash.Essentials.Core/CrestronIO/GenericDigitalInputDevice.cs
Outdated
Show resolved
Hide resolved
src/PepperDash.Essentials.Core/CrestronIO/GenericVersiportInputDevice.cs
Outdated
Show resolved
Hide resolved
…c' into feature/circuittype-property-versiport
The default config for a Fusion room will now NOT subscribe for Fusion schedule push updates unless explicitly requested.
andrew-welker
previously approved these changes
Feb 9, 2026
ndorin
previously approved these changes
Feb 9, 2026
ndorin
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for configuring the input circuit type (normally open "NO" or normally closed "NC") for digital input devices, allowing the input state to be automatically inverted if the circuit is set to "NC". This improves flexibility when integrating different hardware configurations.
Digital Input State Inversion Support:
CircuitTypeproperty to theIOPortConfigclass, allowing configuration of input circuit type ("NO" or "NC"). Defaults to "NO" if not specified.GenericDigitalInputDeviceto use theCircuitTypeproperty: if set to "NC", the input state is inverted when reporting feedback. [1] [2]GenericVersiportDigitalInputDeviceto use theCircuitTypeproperty: if set to "NC", the digital input state is inverted when reporting feedback. [1] [2]…version in digital input devices