Fixes the timer for restart votes so that it uses real time instead of game time. Also fixes the calendar date to lore#487
Conversation
…f server time. Also fixes the in game clock to fit our lore.
|
the calendar year didn't actually change in game I am very confused. |
Ossa88
left a comment
Ossa88
left a comment
There was a problem hiding this comment.
I will properly modularize this a little later, just getting it working for now.
|
Ok, this time I did like 10x the testing. I had incorrectly assumed some time variables were in normal seconds... nah... deciseconds... so when I started to convert them into different times I did not notice since all my tests were done in small batches. WELL... because of this I somehow made the code think it was actually... checks calendar... year 2260 because i accidently multiplied the time code by 10... adding hundreds of years. This version also fixes a flaw I failed to foresee... People voting no... old version would just let the round continue until the next config file said to restart. New version gives ya 30 min + 10 for the jump... to finish RP.... Else if vote passes you get 10 for the jump process. |
Also part of the problem, I did not want the server to also include decimal place seconds, so I added my own converter. Well that was setup wrong. This one so far seems to have finally worked correctly and did not jump around too much. |
|
So far this works, at the conclusion of the round ill work on proper modularization of the code. |
|
Things to update: Allow 2 extensions of 30 min. |
|
Converted from a T/F one time extension to a counter with a 2 maximum currently. |
…ntestdevelopment into pr/Constellado/487
|
Prepping for Merge - Feb 26 |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
…f game time. Also fixes the calendar date to lore (PentestSS13#487) The restart timers are actually set to real time! hurrah! no more restart timers that is supposed to be 3 days ending up going for a week! The lore edit should fix the year to fit our lore. It should now say 2565 (or 2566 after new years). I can make the lore edit modular, but I am putting it like this for now! Restart timers actually counts properly Lore edit good, I think? :cl: add: The in game calendar date is now correct! fix: Server restart votes should actually be called at the right time now. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Ossa88 (SYNAPSE) <MegaMan101@gmail.com>
2 participants
About The Pull Request
The restart timers are actually set to real time! hurrah! no more restart timers that is supposed to be 3 days ending up going for a week!
The lore edit should fix the year to fit our lore. It should now say 2565 (or 2566 after new years).
I can make the lore edit modular, but I am putting it like this for now!
Why It's Good For The Game
Restart timers actually counts properly
Lore edit good, I think?
Changelog
🆑
add: The in game calendar date is now correct!
fix: Server restart votes should actually be called at the right time now.
/:cl: