Repository navigation
fix(tui): bound the refresh cycle and stop overlapping polls - #3
Merged
Merged
Conversation
The cause of the stuck loading state reported in #1 is unconfirmed. This bounds the refresh cycle (credential lookup included) at 15s, prevents overlapping polls, and reports unexpected throws, so any async stall or throw ends in a visible terminal state. - race the whole fetchUsage() cycle against a REFRESH_TIMEOUT_MS deadline and render "request timed out" when the deadline wins - skip a poll while the previous cycle is still in flight, so a slow cycle cannot queue another one every 60s - report an unexpected throw as "unexpected error" without leaking internals, instead of leaving the row on the loading ellipsis - keep the disposed flag authoritative: no status write after unmount Builds on the Show/keyed markup from #1 (saihgupr), which is unchanged here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(tui): bound the refresh cycle and stop overlapping polls
The cause of the stuck loading state reported in #1 is unconfirmed. This
bounds the refresh cycle (credential lookup included) at 15s, prevents
overlapping polls, and reports unexpected throws, so any async stall or
throw ends in a visible terminal state.
and render "request timed out" when the deadline wins
cannot queue another one every 60s
internals, instead of leaving the row on the loading ellipsis
Builds on the Show/keyed markup from #1 (saihgupr), which is unchanged
here.