Adding mssql_audit module for quick enum of exploitable MSSQL configurations#979
Open
mattmillen15 wants to merge 4 commits intoPennyw0rth:mainfrom
Open
Adding mssql_audit module for quick enum of exploitable MSSQL configurations#979mattmillen15 wants to merge 4 commits intoPennyw0rth:mainfrom
mattmillen15 wants to merge 4 commits intoPennyw0rth:mainfrom
Conversation
Implement MSSQL security audit module to check for exploitable configurations. Signed-off-by: mattmillen15 <68832392+mattmillen15@users.noreply.github.com>
Signed-off-by: mattmillen15 <68832392+mattmillen15@users.noreply.github.com>
removed kerberoastable reference cause I totally forgot to remove it after removing the related output... also fixed my parenthesis to be color matched where applicable cause I'm a dummy... Signed-off-by: Matt Millen <68832392+mattmillen15@users.noreply.github.com>
NeffIsBack
requested changes
Nov 3, 2025
Member
NeffIsBack
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks quite cool.
Note for the full review: Check what functionality might overlap with other modules and where it would make the most sense to have it implemented.
swapping out manual coloring for colored function Signed-off-by: Matt Millen <68832392+mattmillen15@users.noreply.github.com>
Author
|
@NeffIsBack, requested changes addressed. Anything else needed to potentially get this one merged? |
Member
|
Time on my side so that i can review the PR😅 But we will get there (some day) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
mssql_auditmodule for identifying exploitable configurations in MSSQL services.Identifies exploitable MSSQL configurations:
Type of change
Setup guide for the review
No external dependencies required. Just a matter of ensuring the mssql_audit.py file is in the nxc/modules folder.
Test with domain credentials against one or more hosts
Test with local SQL auth against one or more hosts
Screenshots
Checklist:
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)