Skip to content

Fix handling of empty SMB share folder#1233

Open
x-way wants to merge 1 commit into
Pennyw0rth:mainfrom
x-way:fix-empty-dir-spider
Open

Fix handling of empty SMB share folder#1233
x-way wants to merge 1 commit into
Pennyw0rth:mainfrom
x-way:fix-empty-dir-spider

Conversation

@x-way
Copy link
Copy Markdown

@x-way x-way commented May 7, 2026

Description

Fix a bug where spider_plus gets stuck in an endless loop crawling an empty SMB share folder.

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)
  • This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)

Setup guide for the review

When having an empty SMB share folder (such as C$), spider_plus gets stuck in an endless reconnect loop as it does not handle the STATUS_NO_SUCH_FILE error properly.

Checklist:

Insert an "x" inside the brackets for completed and relevant items (do not delete options)

  • I have ran Ruff against my changes (poetry: poetry run ruff check ., use --fix to automatically fix what it can)
  • I have added or updated the tests/e2e_commands.txt file if necessary (new modules or features are required to be added to the e2e tests)
  • If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
  • I have linked relevant sources that describes the added technique (blog posts, documentation, etc)
  • I have performed a self-review of my own code (not an AI review)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

@NeffIsBack
Copy link
Copy Markdown
Member

Thanks for the PR, I'll take a look at it soon!

@NeffIsBack NeffIsBack added the bug-fix This Pull Request fixes a bug label May 7, 2026
@NeffIsBack
Copy link
Copy Markdown
Member

Hey, I can't reproduce the issue:
image

It seems fine to me when spider_plus runs into an empty folder. Any specifics that I have to configure? Some specific share setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This Pull Request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants