Skip to content

Refactor change-password#1226

Open
azoxlpf wants to merge 1 commit into
Pennyw0rth:mainfrom
azoxlpf:refactor/change-password
Open

Refactor change-password#1226
azoxlpf wants to merge 1 commit into
Pennyw0rth:mainfrom
azoxlpf:refactor/change-password

Conversation

@azoxlpf
Copy link
Copy Markdown
Contributor

@azoxlpf azoxlpf commented Apr 30, 2026

Description

This PR refactors change-password to add LDAP and Kerberos support alongside SMB (SAMR), so the module works when NTLM is off or RC4 is unavailable. LDAP is included because SAMR password changes do not refresh AES key material in NTDS like an LDAP unicodePwd update, and SAMR changes can be blocked by policy on newer Windows (e.g. Server 2025), where LDAP remains viable when permitted.

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)
  • This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)

Setup guide for the review

run nxc smb/ldap -M change-password

Screenshots (if appropriate):

image

Checklist:

Insert an "x" inside the brackets for completed and relevant items (do not delete options)

  • I have ran Ruff against my changes (poetry: poetry run ruff check ., use --fix to automatically fix what it can)
  • I have added or updated the tests/e2e_commands.txt file if necessary (new modules or features are required to be added to the e2e tests)
  • If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
  • I have linked relevant sources that describes the added technique (blog posts, documentation, etc)
  • I have performed a self-review of my own code (not an AI review)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

@NeffIsBack
Copy link
Copy Markdown
Member

Thanks for the PR!

We should probably just merge #1191 first.

@NeffIsBack NeffIsBack added enhancement New feature or request refactor labels Apr 30, 2026
@azoxlpf
Copy link
Copy Markdown
Contributor Author

azoxlpf commented Apr 30, 2026

Thanks for the PR!

We should probably just merge #1191 first.

Yeah, that would be simpler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants