Fix authentication from CCACHE when using kerberos S4U over SMB#1135
Merged
NeffIsBack merged 3 commits intoPennyw0rth:mainfrom Mar 11, 2026
Merged
Fix authentication from CCACHE when using kerberos S4U over SMB#1135NeffIsBack merged 3 commits intoPennyw0rth:mainfrom
NeffIsBack merged 3 commits intoPennyw0rth:mainfrom
Conversation
Member
|
Thanks for the bug fix PR! I'll take a look at it soon. |
NeffIsBack
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
The S4U login method when using a CCACHE file is not working. The bug comes from a bug that leads to an arror being always raised. Moreover, the code currently search for a ticket for the CIFS service when it should search for a KRBTGT ticket.
Type of change
Setup guide for the review
To trigger the bug ask for a machine account TGT then export it :
export KRB5CCNAME=ticket.ccacheThen use the delegate technique to access the remote computer :
nxc smb TARGET --use-kcache -k --delegate Administrator --self -u 'TARGET$'
You should either see a netexec stack trace or an error saying preauth failed.
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)