Skip to content

Comments

Update to Go 1.26#3946

Draft
ilidemi wants to merge 1 commit intomainfrom
go-1.26
Draft

Update to Go 1.26#3946
ilidemi wants to merge 1 commit intomainfrom
go-1.26

Conversation

@ilidemi
Copy link
Contributor

@ilidemi ilidemi commented Feb 17, 2026

Go 1.26 has three changes of note:

  • new(var) turns a value into a pointer, replacing our shared.Ptr. Implementing
  • Self-referential generics are allowed. This would apply to our RecordItems/PgItems UpdateIfNotExists but also comes with noisy changes across many callsites and it's only really used for the CDC store that we're looking to rip out. Keeping as is
  • fmt.Errorf(constant_string) is now performant but we'd also need to reconfigure linters. Moving to DBI-529: Use golang 1.26's fmt.Errorf instead of errors.New

Draft until clickpipes update so that we don't have to force it

@codecov
Copy link

codecov bot commented Feb 17, 2026

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
1631 2 1629 166
View the top 2 failed test(s) by shortest run time
github.com/PeerDB-io/peerdb/flow/e2e::TestBigQueryClickhouseSuite
Stack Traces | 0s run time
=== RUN   TestBigQueryClickhouseSuite
=== PAUSE TestBigQueryClickhouseSuite
=== CONT  TestBigQueryClickhouseSuite
--- FAIL: TestBigQueryClickhouseSuite (0.00s)
2026/02/17 22:07:28 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/02/17 22:07:28 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/02/17 22:07:28 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pgchclg_5oomid2m.\"test_ddl_drop_column\" ORDER BY id"
2026/02/17 22:07:28 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pgchclg_5oomid2m.\"test_ddl_drop_column\" ORDER BY id"
2026/02/17 22:07:28 INFO [pg_query_executor] declared cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursorQuery="DECLARE peerdb_cursor_14288262830733386103 CURSOR FOR SELECT id, col_to_add FROM e2e_test_pgchclg_5oomid2m.\"test_ddl_drop_column\" ORDER BY id" args=[]
2026/02/17 22:07:28 INFO [pg_query_executor] fetching rows start x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pgchclg_5oomid2m.\"test_ddl_drop_column\" ORDER BY id" channelLen=0
2026/02/17 22:07:28 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_14288262830733386103
2026/02/17 22:07:28 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pgchclg_a7um44ik.\"test_partition_noroot\" ORDER BY id"
2026/02/17 22:07:28 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pgchclg_a7um44ik.\"test_partition_noroot\" ORDER BY id"
2026/02/17 22:07:28 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_14288262830733386103 records=2 bytes=12 channelLen=1
2026/02/17 22:07:28 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pgchclg_5oomid2m.\"test_ddl_drop_column\" ORDER BY id" rows=2 bytes=12 channelLen=1
2026/02/17 22:07:28 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_14288262830733386103
2026/02/17 22:07:28 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_14288262830733386103 records=0 bytes=0 channelLen=0
2026/02/17 22:07:28 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pgchclg_5oomid2m.\"test_ddl_drop_column\" ORDER BY id" rows=0 bytes=0 channelLen=0
2026/02/17 22:07:28 INFO [pg_query_executor] committing transaction x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart
2026/02/17 22:07:28 INFO [pg_query_executor] committed transaction for query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pgchclg_5oomid2m.\"test_ddl_drop_column\" ORDER BY id" rows=2 bytes=12 channelLen=0
2026/02/17 22:07:28 INFO [pg_query_executor] declared cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursorQuery="DECLARE peerdb_cursor_4600226117089669749 CURSOR FOR SELECT id,name,created_at FROM e2e_test_pgchclg_a7um44ik.\"test_partition_noroot\" ORDER BY id" args=[]
2026/02/17 22:07:28 INFO [pg_query_executor] fetching rows start x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pgchclg_a7um44ik.\"test_partition_noroot\" ORDER BY id" channelLen=0
2026/02/17 22:07:28 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_4600226117089669749
2026/02/17 22:07:28 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_4600226117089669749 records=13 bytes=293 channelLen=12
2026/02/17 22:07:28 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pgchclg_a7um44ik.\"test_partition_noroot\" ORDER BY id" rows=13 bytes=293 channelLen=12
2026/02/17 22:07:28 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_4600226117089669749
2026/02/17 22:07:28 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_4600226117089669749 records=0 bytes=0 channelLen=0
2026/02/17 22:07:28 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pgchclg_a7um44ik.\"test_partition_noroot\" ORDER BY id" rows=0 bytes=0 channelLen=0
2026/02/17 22:07:28 INFO [pg_query_executor] committing transaction x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart
2026/02/17 22:07:28 INFO [pg_query_executor] committed transaction for query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pgchclg_a7um44ik.\"test_partition_noroot\" ORDER BY id" rows=13 bytes=293 channelLen=0
github.com/PeerDB-io/peerdb/flow/e2e::TestBigQueryClickhouseSuite/Test_GCS_Cleanup_After_Initial_Load
Stack Traces | 42.2s run time
=== RUN   TestBigQueryClickhouseSuite/Test_GCS_Cleanup_After_Initial_Load
=== PAUSE TestBigQueryClickhouseSuite/Test_GCS_Cleanup_After_Initial_Load
=== CONT  TestBigQueryClickhouseSuite/Test_GCS_Cleanup_After_Initial_Load
    bigquery_source_test.go:846: ClickHouse database: e2e_test_bqch_xfxu3xlq
    bigquery_source_test.go:852: Creating test table test_gcs_cleanup_7fppjflx
2026/02/17 22:06:46 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_7xsagkbw.\"t1\" ORDER BY id"
2026/02/17 22:06:46 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_7xsagkbw.\"t1\" ORDER BY id"
2026/02/17 22:06:46 INFO [pg_query_executor] declared cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursorQuery="DECLARE peerdb_cursor_7497122987279922404 CURSOR FOR SELECT id,val FROM e2e_test_api_7xsagkbw.\"t1\" ORDER BY id" args=[]
2026/02/17 22:06:46 INFO [pg_query_executor] fetching rows start x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_7xsagkbw.\"t1\" ORDER BY id" channelLen=0
2026/02/17 22:06:46 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_7497122987279922404
2026/02/17 22:06:46 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_7497122987279922404 records=2 bytes=19 channelLen=1
2026/02/17 22:06:46 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_7xsagkbw.\"t1\" ORDER BY id" rows=2 bytes=19 channelLen=0
2026/02/17 22:06:46 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_7497122987279922404
2026/02/17 22:06:46 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_7497122987279922404 records=0 bytes=0 channelLen=0
2026/02/17 22:06:46 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_7xsagkbw.\"t1\" ORDER BY id" rows=0 bytes=0 channelLen=0
2026/02/17 22:06:46 INFO [pg_query_executor] committing transaction x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart
2026/02/17 22:06:46 INFO [pg_query_executor] committed transaction for query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_7xsagkbw.\"t1\" ORDER BY id" rows=2 bytes=19 channelLen=0
    bigquery_source_test.go:900: Inserted 5 rows into source table
2026/02/17 22:06:49 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/02/17 22:06:49 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
    bigquery_source_test.go:922: WaitFor data replicated 2026-02-17 22:06:50.519683363 +0000 UTC m=+199.491978923
    bigquery_source_test.go:922: code: 60, message: Unknown table expression identifier 'test_gcs_cleanup_7fppjflx_dst' in scope SELECT id FROM test_gcs_cleanup_7fppjflx_dst FINAL WHERE _peerdb_is_deleted = 0 ORDER BY 1 ASC SETTINGS use_query_cache = false
2026/02/17 22:06:51 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_trexynsd.\"t1\" ORDER BY id"
2026/02/17 22:06:51 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_trexynsd.\"t1\" ORDER BY id"
2026/02/17 22:06:51 INFO [pg_query_executor] declared cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursorQuery="DECLARE peerdb_cursor_8198983301600322439 CURSOR FOR SELECT id,val FROM e2e_test_api_trexynsd.\"t1\" ORDER BY id" args=[]
2026/02/17 22:06:51 INFO [pg_query_executor] fetching rows start x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_trexynsd.\"t1\" ORDER BY id" channelLen=0
2026/02/17 22:06:51 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8198983301600322439
2026/02/17 22:06:51 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8198983301600322439 records=2 bytes=19 channelLen=1
2026/02/17 22:06:51 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_trexynsd.\"t1\" ORDER BY id" rows=2 bytes=19 channelLen=0
2026/02/17 22:06:51 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8198983301600322439
2026/02/17 22:06:51 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8198983301600322439 records=0 bytes=0 channelLen=0
2026/02/17 22:06:51 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_trexynsd.\"t1\" ORDER BY id" rows=0 bytes=0 channelLen=0
2026/02/17 22:06:51 INFO [pg_query_executor] committing transaction x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart
2026/02/17 22:06:51 INFO [pg_query_executor] committed transaction for query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,val FROM e2e_test_api_trexynsd.\"t1\" ORDER BY id" rows=2 bytes=19 channelLen=0
    bigquery_source_test.go:922: code: 60, message: Unknown table expression identifier 'test_gcs_cleanup_7fppjflx_dst' in scope SELECT id FROM test_gcs_cleanup_7fppjflx_dst FINAL WHERE _peerdb_is_deleted = 0 ORDER BY 1 ASC SETTINGS use_query_cache = false
    bigquery_source_test.go:922: q.NumRecords: 5
    bigquery_source_test.go:922: other.NumRecords: 0
    bigquery_source_test.go:922: q.NumRecords: 5
    bigquery_source_test.go:922: other.NumRecords: 0
    bigquery_source_test.go:922: q.NumRecords: 5
    bigquery_source_test.go:922: other.NumRecords: 0
    bigquery_source_test.go:924: Verifying data in ClickHouse
    bigquery_source_test.go:931: Checking GCS staging path for exported objects
    bigquery_source_test.go:933: WaitFor GCS path gs:.../peerdb_bigquery_source_test_do_not_remove/test_cleanup/test_gcs_cleanup_7fppjflx to be cleaned up 2026-02-17 22:06:57.921105702 +0000 UTC m=+206.893401262
2026/02/17 22:06:57 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="\n\t\tSELECT COUNT(*) FROM peerdb_stats.flow_errors\n\t\tWHERE error_type='error' AND position('test_cancel_add_cancel_api_uf55syom' in flow_name) > 0\n\t\tAND error_message ILIKE '%while pushing to view e2e_test_api_uf55syom.t2_mv_third%'"
2026/02/17 22:06:57 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="\n\t\tSELECT COUNT(*) FROM peerdb_stats.flow_errors\n\t\tWHERE error_type='error' AND position('test_cancel_add_cancel_api_uf55syom' in flow_name) > 0\n\t\tAND error_message ILIKE '%while pushing to view e2e_test_api_uf55syom.t2_mv_third%'"
2026/02/17 22:06:57 INFO [pg_query_executor] declared cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursorQuery="DECLARE peerdb_cursor_723640838282976287 CURSOR FOR \n\t\tSELECT COUNT(*) FROM peerdb_stats.flow_errors\n\t\tWHERE error_type='error' AND position('test_cancel_add_cancel_api_uf55syom' in flow_name) > 0\n\t\tAND error_message ILIKE '%while pushing to view e2e_test_api_uf55syom.t2_mv_third%'" args=[]
2026/02/17 22:06:57 INFO [pg_query_executor] fetching rows start x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="\n\t\tSELECT COUNT(*) FROM peerdb_stats.flow_errors\n\t\tWHERE error_type='error' AND position('test_cancel_add_cancel_api_uf55syom' in flow_name) > 0\n\t\tAND error_message ILIKE '%while pushing to view e2e_test_api_uf55syom.t2_mv_third%'" channelLen=0
2026/02/17 22:06:57 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_723640838282976287
2026/02/17 22:06:57 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_723640838282976287 records=1 bytes=8 channelLen=0
2026/02/17 22:06:57 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="\n\t\tSELECT COUNT(*) FROM peerdb_stats.flow_errors\n\t\tWHERE error_type='error' AND position('test_cancel_add_cancel_api_uf55syom' in flow_name) > 0\n\t\tAND error_message ILIKE '%while pushing to view e2e_test_api_uf55syom.t2_mv_third%'" rows=1 bytes=8 channelLen=0
2026/02/17 22:06:57 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_723640838282976287
2026/02/17 22:06:57 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_723640838282976287 records=0 bytes=0 channelLen=0
2026/02/17 22:06:57 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="\n\t\tSELECT COUNT(*) FROM peerdb_stats.flow_errors\n\t\tWHERE error_type='error' AND position('test_cancel_add_cancel_api_uf55syom' in flow_name) > 0\n\t\tAND error_message ILIKE '%while pushing to view e2e_test_api_uf55syom.t2_mv_third%'" rows=0 bytes=0 channelLen=0
2026/02/17 22:06:57 INFO [pg_query_executor] committing transaction x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart
2026/02/17 22:06:57 INFO [pg_query_executor] committed transaction for query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="\n\t\tSELECT COUNT(*) FROM peerdb_stats.flow_errors\n\t\tWHERE error_type='error' AND position('test_cancel_add_cancel_api_uf55syom' in flow_name) > 0\n\t\tAND error_message ILIKE '%while pushing to view e2e_test_api_uf55syom.t2_mv_third%'" rows=1 bytes=8 channelLen=0
    bigquery_source_test.go:933: UNEXPECTED TIMEOUT GCS path gs:.../peerdb_bigquery_source_test_do_not_remove/test_cleanup/test_gcs_cleanup_7fppjflx to be cleaned up 2026-02-17 22:07:28.506767594 +0000 UTC m=+237.479063152
--- FAIL: TestBigQueryClickhouseSuite/Test_GCS_Cleanup_After_Initial_Load (42.21s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant