Skip to content

workaround for overriding default timeout limitation#3939

Merged
jgao54 merged 3 commits intomainfrom
customer-joy-timeout-issue
Feb 17, 2026
Merged

workaround for overriding default timeout limitation#3939
jgao54 merged 3 commits intomainfrom
customer-joy-timeout-issue

Conversation

@jgao54
Copy link
Copy Markdown
Contributor

@jgao54 jgao54 commented Feb 16, 2026

collection.Find hard-codes OmitMaxTimeMs(true) and honors the server-side defaultMaxTimeMS. It's not always practical to ask user to set a very long default timeout on the server-side; however connection string does not support passing maxTimeMS as a parameter. Workaround is to use the generic RunCommandCursor instead of Collection.Find which will derive the maxTimeMS using the context deadline, which us set to 5 days by default on our end

@jgao54 jgao54 marked this pull request as ready for review February 16, 2026 12:20
@jgao54 jgao54 requested a review from ilidemi February 16, 2026 12:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
1664 2 1662 166
View the top 2 failed test(s) by shortest run time
github.com/PeerDB-io/peerdb/flow/e2e::TestPeerFlowE2ETestSuitePG_CH_Cluster
Stack Traces | 0.01s run time
=== RUN   TestPeerFlowE2ETestSuitePG_CH_Cluster
=== PAUSE TestPeerFlowE2ETestSuitePG_CH_Cluster
=== CONT  TestPeerFlowE2ETestSuitePG_CH_Cluster
--- FAIL: TestPeerFlowE2ETestSuitePG_CH_Cluster (0.01s)
github.com/PeerDB-io/peerdb/flow/e2e::TestPeerFlowE2ETestSuitePG_CH_Cluster/Test_Unbounded_Numeric_With_FF
Stack Traces | 5.09s run time
=== RUN   TestPeerFlowE2ETestSuitePG_CH_Cluster/Test_Unbounded_Numeric_With_FF
=== PAUSE TestPeerFlowE2ETestSuitePG_CH_Cluster/Test_Unbounded_Numeric_With_FF
=== CONT  TestPeerFlowE2ETestSuitePG_CH_Cluster/Test_Unbounded_Numeric_With_FF
2026/02/17 18:26:03 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/02/17 18:26:03 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
    clickhouse_test.go:751: Failed to connect temporal client: failed reaching server: context deadline exceeded
    clickhouse.go:114: begin tearing down postgres schema pgchcl_6gctjo1x
--- FAIL: TestPeerFlowE2ETestSuitePG_CH_Cluster/Test_Unbounded_Numeric_With_FF (5.09s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@jgao54 jgao54 enabled auto-merge (squash) February 17, 2026 19:07
@jgao54 jgao54 merged commit 1fa9eb1 into main Feb 17, 2026
18 of 19 checks passed
@jgao54 jgao54 deleted the customer-joy-timeout-issue branch February 17, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants