Corrections and clarifications to heterotrophic respiration scheme by dlebauer · Pull Request #219 · PecanProject/sipnet

dlebauer · 2026-01-07T21:57:52Z

Description

Based on conversation today, this equation was incorrect because the $f_\text{litter}$ only applies to litter, not to soil (since decomposed soil is either respired or stays in the soil pool).

In addition to clarifying and fixing heterotrophic respiration, I also clarified the section and fixed typos and other inconsistencies.

This was incorrect

Correct (🤞🏻):

Side note on notation

Currently, fluxes are (hopefully consistently) indexed by their destination pool, but this is ambiguous e.g.:

$$\large{F^C_\text{soil}}$$

is the flux to soil, but could refer to flux from roots, litter, or OM additions. I've changed some of these to use

$$\large{F_\text{to, from}}$$

notation but perhaps it would be more clear to make it

$$\large{F_{\text{from}\rightarrow \text{to}}}$$

If so I can write this up as perhaps a 'good first issue' to follow #203.

Copilot

Pull request overview

This PR corrects the heterotrophic respiration equations in the model documentation by properly separating litter and soil respiration components. The key fix addresses an error where the respiration fraction parameter $f_{\text{litter}}$ was incorrectly applied to both litter and soil pools, when it should only apply to litter decomposition.

Key Changes:

Reformulated the heterotrophic respiration equation to explicitly separate soil and litter respiration components
Clarified that litter decomposition is partitioned between respiration and soil carbon transfer using $f_{\text{litter}}$
Updated parameter tables to improve notation consistency and remove deprecated/unused parameters
Cleaned up documentation by removing commented-out sections and consolidating parameter descriptions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
docs/parameters.md	Renamed "Litter Quality Parameters" to "Stoichiometry Parameters", updated parameter symbols (including $f_{\text{litter}}$ and CN parameters), added methane oxidation rate parameter, removed deprecated microbe and methane parameter sections, and cleaned up formatting
docs/model-structure.md	Restructured heterotrophic respiration section to separate litter and soil components, added new equations (4a, 4b) to clarify litter decomposition partitioning, rewrote explanatory text for improved clarity, and removed the old combined respiration equation that incorrectly applied $f_{R_H}$ to both pools

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Alomir · 2026-01-07T23:03:07Z

A couple of minor comments:

In Eq 3 in the screenshot above, I don't think the "fert" in the LHS is relevant; the RHS is more than just the fert contribution.
I like the F_{from->to} form, hard to misinterpret that. OK, harder to misinterpret that...

Alomir · 2026-01-07T23:04:14Z

~~Another comment - so we are concluding that litter decomp/respiration does NOT need the CN or tillage dependency term?~~

Hmmm, hold on, mis-read...

Don't the two R_H_litter calcs - (5) and last part of (7) - contradict each other?

Alomir · 2026-01-07T23:09:44Z

~~One more - I think harvest plays in to dC_soil/dt (eq Braswell A3), unless we are implicitly including it in the belowground plant turnover.~~

Reading the Harvest section, I see that it is. This comment can be ignored.

dlebauer · 2026-01-08T19:53:34Z


 Where $F^C_\text{litter}$ is the carbon flux from aboveground plant biomass into the litter pool through senescence, harvest transfer, and organic matter additions \eqref{eq:litter_flux}. Belowground turnover is routed directly to the soil carbon pool (see Soil Carbon).
-$F^C_{\text{decomp}}$ is the total carbon flux lost from the litter pool due to decomposition and includes both transfer and respiration \eqref{eq:decomp_carbon}.
+$F^C_{\text{decomp}}$ is the total litter decomposition flux, representing the rate at which litter carbon is processed by microbial activity.


Suggested change

$F^C_{\text{decomp}}$ is the total litter decomposition flux, representing the rate at which litter carbon is processed by microbial activity.

$F^C_{\text{decomp}}$ is the total litter decomposition flux, representing the rate at which litter carbon is processed by microbial activity prior to partitioning among downstream fluxes.

Co-authored-by: David LeBauer <dlebauer@gmail.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Alomir

I think this is good to go after the two open suggestions are handled (I suggest applying them).

Thanks for working through this!

Co-authored-by: Mike Longfritz <Mike.Longfritz@gmail.com>

@dlebauer

…ecanProject#219) * minor corrections and clarifications to heterotrophic respiration scheme * additional clarification * additional clarification * more fixes * Update docs/parameters.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/parameters.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/model-structure.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * additional clarifications and fixes * Update docs/parameters.md * removed redundant definitions from model structure doc * Apply suggestion from @dlebauer Co-authored-by: David LeBauer <dlebauer@gmail.com> * Apply suggestion from @dlebauer Co-authored-by: David LeBauer <dlebauer@gmail.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update model-structure.md Co-authored-by: Mike Longfritz <Mike.Longfritz@gmail.com> * clarify soil and litter decomp explanation --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Mike Longfritz <Mike.Longfritz@gmail.com>

minor corrections and clarifications to heterotrophic respiration scheme

be104f8

Copilot AI review requested due to automatic review settings January 7, 2026 21:57

dlebauer requested review from Alomir, infotroph, mdietze and mswilburn as code owners January 7, 2026 21:57

Copilot started reviewing on behalf of dlebauer January 7, 2026 21:58 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

dlebauer and others added 5 commits January 7, 2026 15:04

additional clarification

bb96e57

additional clarification

c693082

more fixes

3aee072

Update docs/parameters.md

942a9d4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update docs/parameters.md

0dd61c7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

dlebauer requested a review from Copilot January 7, 2026 22:34

Copilot started reviewing on behalf of dlebauer January 7, 2026 22:34 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Comment thread docs/model-structure.md Outdated

Comment thread docs/model-structure.md Outdated

Comment thread docs/model-structure.md Outdated

Comment thread docs/model-structure.md Outdated

dlebauer and others added 2 commits January 7, 2026 15:47

Update docs/model-structure.md

d2e2cb9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

additional clarifications and fixes

93f1cb8

dlebauer commented Jan 7, 2026

View reviewed changes

Comment thread docs/model-structure.md Outdated

Comment thread docs/parameters.md Outdated

Update docs/parameters.md

ef86ec3

dlebauer changed the title ~~minor corrections and clarifications to heterotrophic respiration scheme~~ Corrections and clarifications to heterotrophic respiration scheme Jan 7, 2026

merge

2076dc8

Alomir reviewed Jan 8, 2026

View reviewed changes

Comment thread docs/model-structure.md

dlebauer commented Jan 8, 2026

View reviewed changes

removed redundant definitions from model structure doc

16bd4be

dlebauer requested a review from Alomir January 8, 2026 20:11

Alomir reviewed Jan 9, 2026

View reviewed changes

Comment thread docs/model-structure.md Outdated

dlebauer commented Jan 9, 2026

View reviewed changes

Comment thread docs/model-structure.md

dlebauer commented Jan 10, 2026

View reviewed changes

Comment thread docs/model-structure.md Outdated

Alomir and others added 5 commits January 12, 2026 12:52

Apply suggestion from @dlebauer

af55f0c

Co-authored-by: David LeBauer <dlebauer@gmail.com>

Apply suggestion from @dlebauer

413a94a

Co-authored-by: David LeBauer <dlebauer@gmail.com>

Apply suggestion from @Copilot

d1990d7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

af29ebc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'master' into split_rh_docs

9b48672

Alomir reviewed Jan 12, 2026

View reviewed changes

Comment thread docs/model-structure.md Outdated

Alomir approved these changes Jan 12, 2026

View reviewed changes

dlebauer and others added 2 commits January 12, 2026 11:19

Update model-structure.md

8f0871c

Co-authored-by: Mike Longfritz <Mike.Longfritz@gmail.com>

clarify soil and litter decomp explanation

69e3c83

dlebauer merged commit dceb9c0 into master Jan 12, 2026
11 checks passed

dlebauer deleted the split_rh_docs branch January 12, 2026 18:53

dlebauer restored the split_rh_docs branch January 21, 2026 01:20

	$F^C_{\text{decomp}}$ is the total litter decomposition flux, representing the rate at which litter carbon is processed by microbial activity.
	$F^C_{\text{decomp}}$ is the total litter decomposition flux, representing the rate at which litter carbon is processed by microbial activity prior to partitioning among downstream fluxes.

Conversation

dlebauer commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

This was incorrect

Correct (🤞🏻):

Side note on notation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes:

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alomir commented Jan 7, 2026

Uh oh!

Alomir commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alomir commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dlebauer Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alomir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dlebauer commented Jan 7, 2026 •

edited

Loading

Alomir commented Jan 7, 2026 •

edited

Loading

Alomir commented Jan 7, 2026 •

edited

Loading