Refactor workflow to stateless run manifest architecture and SA input design coordination#3708
Merged
infotroph merged 90 commits intoPecanProject:developfrom Feb 26, 2026
Merged
Conversation
…g in read.ensemble.output to fix I/O bottleneck
…g in read.sa.output to fix I/O bottleneck
14 tasks
infotroph
reviewed
Dec 18, 2025
14 tasks
dlebauer
approved these changes
Feb 25, 2026
All requests changes and suggestions have been addressed
Member
|
failing build - looks like base/workflows/NAMESPACE needs to be re-auto-generated devtools::document('base/workflows') |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
Refactor workflow to stateless run manifest architecture and SA input design coordination
infotroph
requested changes
Feb 25, 2026
| @@ -1,8 +1,12 @@ | |||
| # PEcAn.workflow 1.10.0.9000 | |||
| # Unreleased | |||
Member
There was a problem hiding this comment.
Suggested change
| # Unreleased | |
| PEcAn.workflow 1.10.0.9000 |
infotroph
reviewed
Feb 25, 2026
Comment on lines
+7
to
+9
| # PEcAn.workflow 1.10.0.9000 | ||
|
|
||
| * Removed `tests/Rcheck_reference.log`, which was used to ignore historic check messages that have now been fixed. |
Member
There was a problem hiding this comment.
.9000 means unreleased, so if a .9000 section exists you should always add entries there rather than start new sections above it.
| #' result object with the design matrix in \code{$X} plus additional | ||
| #' components for Sobol index calculations. | ||
| #' | ||
| #' @details |
infotroph
reviewed
Feb 25, 2026
infotroph
approved these changes
Feb 25, 2026
Merged
via the queue into
PecanProject:develop
with commit Feb 26, 2026
dab62a6
19 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #3692
run.write.configsto generate aruns_manifest.csvfile containing run metadata (run_id, site_id, pft_name, trait, quantile, type) instead of appending to samples.Rdata.fixes #3693
read.sa.outputandread.ensemble.outputto pass the full vector of requested variables to read.output in a single call.Additionally this PR separates input design generation for SA and ensemble runs, fixing dimension mismatch errors in multisite workflows.
previously both SA and ensemble used a single
input_designmatrix, causing failures when:causes in dimension mismatch errors in input design coordination.
runModule.run.write.configsgenerates separateens_input_designandsa_input_designmatrices.run.write.configsaccepts bothinput_design_ensandinput_design_saparameters.Old
input_designparameter still works with deprecation warning.Motivation and Context
Review Time Estimate
Types of changes
Checklist: