This repository was archived by the owner on Sep 7, 2025. It is now read-only.
Add @ChopstixCS's code that adds support for Catalina & @3raxton's code that adds a new meta postion to Playbox#34
Open
3raxton wants to merge 78 commits intoPe8er:masterfrom
Open
Add @ChopstixCS's code that adds support for Catalina & @3raxton's code that adds a new meta postion to Playbox#343raxton wants to merge 78 commits intoPe8er:masterfrom
3raxton wants to merge 78 commits intoPe8er:masterfrom
Conversation
This update includes the code that @ChopstixCS wrote to make Playbox.widget compatible with Catalina. Furthermore, this code adds a new meta position that I wrote to mix both the outside and inside meta positions.
This update includes the code that @ChopstixCS wrote to make Playbox.widget compatible with Catalina. Furthermore, this code adds a new meta position that I wrote to mix both the outside and inside meta positions.
Add more example settings for Playbox.widget README.md
Compress the code that combines both @ChopstixCS & the code that I wrote to be a .zip file for Catalina users.
|
Just tested this on 10.15.2, works great! Left one comment about the "small" min-width |
grrowl
reviewed
Feb 26, 2020
Actually make "small" small Co-Authored-By: Tom McKenzie <tom@chillidonut.com>
3raxton
commented
Feb 28, 2020
Author
3raxton
left a comment
3raxton
left a comment
There was a problem hiding this comment.
Added a bit of info in the code for the #mixed metaPosition that I forgot to add in my repo.
3raxton
commented
Feb 28, 2020
Author
3raxton
left a comment
3raxton
left a comment
There was a problem hiding this comment.
Added more details to README.md for #mixed metaPosition
While using the widget, I noticed that some song and album names were generating "invalid" filenames for the artwork, resulting in the cover not being shown at all. This fixes it by adding `, \ : ?` to the list of character to exclude when generating the artwork filename.
Übersicht was updated to 1.5 and created an issue where widgets that covered the desktop would disable access to any desktop items. I've added pointer-events: none on line 35 to prevent this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes the code that @ChopstixCS wrote to make Playbox.widget compatible with Catalina. Furthermore, this code adds a new meta position that I wrote to mix both the outside and inside meta positions.
I realize that there have been changes made to the master branch after @ChopstixCS released their .zip for Catalina support. I would be happy to help combine both the new version of Playbox and the version that works for Catalina if you would like any help. Please let me know your thoughts on this pull request.