fix(login): render dev-login form client-only to avoid hydration mismatch#6
Open
RisingOrange wants to merge 1 commit intodevfrom
Open
fix(login): render dev-login form client-only to avoid hydration mismatch#6RisingOrange wants to merge 1 commit intodevfrom
RisingOrange wants to merge 1 commit intodevfrom
Conversation
…atch Password manager extensions inject autofill icons / fill buttons into the input fields after SSR but before React hydration, causing a recoverable hydration mismatch. suppressHydrationWarning only covers attribute mismatches on a single element, not new injected children. Gate the form behind a useEffect-mounted flag so it renders client-only, sidestepping hydration entirely. The form is dev-only, so SSR was never useful here.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Password-manager extensions (Bitwarden, 1Password, LastPass, Dashlane) inject autofill icons and fill buttons into the dev-login form's
<input>fields after SSR but before React hydration. React flags this as a hydration mismatch on every page load of/loginin development.suppressHydrationWarningonly covers attribute mismatches on a single element — it doesn't catch a new injected child node — so attributes-level suppression wasn't enough.Gate the form behind a
useEffect-mounted flag so it renders client-only. The form is dev-only (isDevgated inpage.tsx), so SSR was never useful here.Test plan
/loginwith a password-manager extension installed → no hydration warning in browser console.isDev && ...).