Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
---
name: Bug report
about: Report a bug
title: "[Bug] "
labels: bug

---

## Description

Describe the bug.

## Steps to reproduce

1. xxx
2. xxx
3. xxx

## Expected behaviour

Describe what you expect to happen.

## Actual behaviour

Describe what actually happens.

# Additional info

If you have any videos, screenshots or logs provide them here.
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
blank_issues_enabled: false
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
name: Feature request
about: Suggest a new feature
title: "[Feature] "
labels: enhancement

---

## Description

Describe the feature you would like to see.

## Why?

Explain why this should be considered and what would this enhance or allow for.
10 changes: 10 additions & 0 deletions .github/ISSUE_TEMPLATE/other.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
name: Other
about: Report a issue not listed
title: "[Other] "

---

## Description

Describe the issue.
18 changes: 18 additions & 0 deletions .github/pull_request_template.md.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
## Description

Describe the changes made.

<!-- if this PR fixes an issue, link the issue -->
Fixes #

## Testing

<!-- if no testing was required, ignore this -->

* [ ] Tested in Debug
* [ ] Tested in Release

## Checklist

* [ ] Your changes were not written by AI
* [ ] Your changes follow the project's conventions and style
12 changes: 10 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,27 @@

A project that aims at rebuilding the 4J libraries source code via decompilation for the Minecraft: Legacy Console Edition

## NOTICE
## Known Bugs

There's a bug in the main game code where the depth stencil view descriptor isn't zero initialized, this happens in the file ``Windows64_Minecraft.cpp`` at the
```D3D11_DEPTH_STENCIL_VIEW_DESC descDSView;``` line


This causes the depth stencil view creation to fail and consequently breaks the game, to fix this you will need to add the following line after the definition described:
This causes the depth stencil view creation to fail and visually breaks the game, to fix this you will need to add the following line below the ``descDSView`` definition in ``Windows64_Minecraft.cpp``:

```ZeroMemory(&descDSView, sizeof(descDSView));```

This issue only happens when building with newer versions of the Visual Studio compiler, Visual Studio 2012 isn't affected by this, so if you're working on a fork of the main source
remember to add this line to avoid breaking the game for other people

## Branches

Currently there are two branches for the project: [master](https://github.com/Patoke/4JLibs/tree/master) and [legacy-4jlibs](https://github.com/Patoke/4JLibs/tree/legacy-4jlibs)

The `master` branch is where we extend the `legacy-4jlibs` branch and implement new features or fixes that the original libraries may not have had.

The `legacy-4jlibs` branch is where we aim to achieve a 1:1 decompilation using [objdiff](https://github.com/encounter/objdiff) for matching. Once that is achieved, the branch will be left as is.

## Why?

This would allow compiling the Minecraft: Legacy Console Edition source code from newer versions of Visual Studio, expand the Renderer code, add new Input support, etc...
Expand Down
2 changes: 1 addition & 1 deletion Windows_Libs/Dev/Render/Renderer.h
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ class Renderer
bool m_bSuspended;

// @Patoke add
ID3D11Texture2D *m_backBufferTexture = NULL;
ID3D11Texture2D *m_backBufferTexture;
};

// Singleton
Expand Down
Loading