Skip to content

Rework TradeQueryGenerator to use exported stat names and values #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vaisest wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Rework TradeQueryGenerator to use exported stat names and values #2355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcd9cbb
Rework TradeQueryGenerator to use exported stat names and values
vaisest Jul 7, 2026
32071dd
Fix
vaisest Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/System/TestStatDescriber_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describe("StatDescriber getScope scenarios", function()
for _, case in ipairs(cases) do
it(case.name, function()
ConPrintf("[StatDescriber getScope] %s", case.name)
local describe = require("Modules/StatDescriber")
local describe = require("Modules/StatDescriber").describeStats

if case.shouldSucceed then
local out, lineMap = describe(case.stats, case.scope)
Expand Down
9 changes: 0 additions & 9 deletions spec/System/TestTradeQueryGenerator_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,6 @@ describe("TradeQueryGenerator", function()
local mock_queryGen = new("TradeQueryGenerator", { itemsTab = {} })

describe("ProcessMod", function()
-- Pass: Mod line maps correctly to trade stat entry without error
-- Fail: Mapping fails (e.g., no match found), indicating incomplete stat parsing for curse mods, potentially missing curse-enabling items in queries
it("handles special curse case", function()
local mod = { tradeHashes = {[30642521] = {"You can apply an additional Curse"}}, type = "Prefix", weightKey = {}, weightVal = {} }
mock_queryGen.modData = { Explicit = {} }
mock_queryGen:ProcessMod(mod)
-- Simplified assertion; in full impl, check modData
assert.is_true(true)
end)
end)

describe("WeightedRatioOutputs", function()
Expand Down
Loading
Loading