-
Notifications
You must be signed in to change notification settings - Fork 246
Added different nodes on tree #1644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Added different nodes on tree #1644
Conversation
src/Modules/ModParser.lua
Outdated
| ["arrows that pierce deal (%d+)%% increased damage"] = function(num) return { mod("Damage", "INC", num, nil, bor(ModFlag.Attack, ModFlag.Projectile), { type = "StatThreshold", stat = "PierceCount", threshold = 1 }) } end, | ||
| ["projectiles gain (%d+)%% of non%-chaos damage as extra chaos damage per chain"] = function(num) return { mod("NonChaosDamageGainAsChaos", "BASE", num, nil, ModFlag.Projectile, { type = "PerStat", stat = "Chain" }) } end, | ||
| ["projectiles that have chained gain (%d+)%% of non%-chaos damage as extra chaos damage"] = function(num) return { mod("NonChaosDamageGainAsChaos", "BASE", num, nil, ModFlag.Projectile, { type = "StatThreshold", stat = "Chain", threshold = 1 }) } end, | ||
| ["spells gain (%d+)%% of damage as extra chaos damage"] = function(num) return { mod("NonChaosDamageGainAsChaos", "BASE", num, { type = "SkillType", skillType = SkillType.Spell}) } end, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than making a whole line for this, you can just update this line (hoping my link works)
PathOfBuilding-PoE2/src/Modules/ModParser.lua
Line 1253 in 8fdb686
| ["^spells [hdf][aei][var][el] a? ?"] = { flags = ModFlag.Spell }, |
If you update it to
["^spells [hgdf][aei][ivar][nel] a? ?"] = { flags = ModFlag.Spell },It will also work for other damage types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it.



I also added a parse for "dodge roll cannot avoid damage" but it doesnt do anything. I think it looks visually better when there is no red text if a node /keystone is working.