Add parsing support for charges and Volatility #1541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Steps taken to verify a working solution:
Other discussion:
The "% chance to gain "
modFormthat resolved to "FLAG" was swallowing all charge and volatility mods. I resolved this by deleting this line entirely (it was only used for the "Arcane Surge on Crit" mod) and modifying the "CHANCE" parsing step to allowmodTypeoverrides.I would like some feedback on this approach. My other idea for addressing this was to keep the "% chance to gain"
modFormline but resolve it to a new form calledPROC. When parsed,PROCmods would first check for a matching flag and then move on to scanning themodNameListif one is not found.