-
Notifications
You must be signed in to change notification settings - Fork 72
fix: adjusted singbox template to the latest format #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
WalkthroughA DNS and outbound configuration restructuring for Sing Box: DNS entries convert from reference-based definitions to explicit per-server types; proxy selector outbound and direct outbound are redefined with proper structure; a new Best Latency urltest outbound is introduced; route configuration consolidates with a default domain resolver setting. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/templates/singbox/default.json (1)
10-11: DNS configuration uses hard-coded Google DNS server.The dns-remote entry is configured with
"server": "8.8.8.8"(Google Public DNS). While this is a reasonable default, consider whether this template should be more flexible or include comments guiding users to customize DNS servers per their region/privacy requirements.Also applies to: 15-16
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/templates/singbox/default.json(3 hunks)
🔇 Additional comments (2)
app/templates/singbox/default.json (2)
42-50: Verify empty outbounds arrays in proxy selector and Best Latency entries.The changes introduce empty
outbounds: []arrays in two places:
- Line 43: Proxy selector outbound with empty outbounds
- Line 49: Best Latency (urltest) outbound with empty outbounds
For a template, empty arrays may be intentional placeholders for users to populate. However,
urltestoutbounds typically require targets to test against. Confirm these empty arrays align with the latest Sing Box template format and that users understand they must be populated or that the configuration will function correctly in this state.
69-69: Verify default_domain_resolver reference is correct.Line 69 sets
"default_domain_resolver": "dns-remote", which correctly references the tag defined at line 9. This cross-reference is valid. Confirm this setting aligns with your intended DNS routing behavior for the template.Also applies to: 9-9
|
This template works for the latest Android client of SingBox but I didn't know SinBox hasn't updated it's iPhone client for 10 months, so you need to leave the PR open and merge it when SingBox updates it's iPhone client. |
|
i will merg this after ios version released |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.