Remove unneeded System.IO.Hashing in test project and clean up project files#105
Merged
Conversation
| extension(EndpointConfiguration endpointConfiguration) | ||
| { | ||
| public CloudEventsConfiguration GetCloudEventsConfiguration() => endpointConfiguration.GetSettings().Get<CloudEventsConfiguration>(CloudEventsEndpointConfigurationExtensions.CloudEventsConfigurationSettingsKey); | ||
| public CloudEventsConfiguration GetCloudEventsConfiguration() => endpointConfiguration.GetSettings().Get<CloudEventsConfiguration>("NServiceBus.Envelope.CloudEvents.Configuration"); |
Contributor
There was a problem hiding this comment.
Why is this object not used as the key?
Member
Author
There was a problem hiding this comment.
Didn’t even think about that. Is that a change we can make but not release?
Member
There was a problem hiding this comment.
I'd say yes since we don't treat those keys as public API?
Contributor
There was a problem hiding this comment.
Correct they are not public APIs
danielmarbach
approved these changes
Jun 3, 2026
andreasohlund
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.