Fix os independent paths#2043
Merged
benclifford merged 2 commits intoParsl:masterfrom May 3, 2021
Merged
Conversation
originally by j.m.o.rantaharju@swansea.ac.uk
benclifford
approved these changes
May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was originally added by @rantahar to a fork of
libsubmitwhich means it has to be reintroduced again due to all the structural changes.I've found this PR a bit later and it was created not long before the project assimilation so it didn't have a chance to be merged. I'm not sure about line endings though, it looks like a reasonable thing since there is going to be Linux running on the other side.
Description
Rather than stacking strings together it's much better to use
osmodule to make it work on Windows as well.Type of change
Choose which options apply, and delete the ones which do not apply.