Add support in convert.nemo_to_sgrid for depthw coordinate#2626
Open
VeckoTheGecko wants to merge 4 commits intoParcels-code:mainfrom
Open
Add support in convert.nemo_to_sgrid for depthw coordinate#2626VeckoTheGecko wants to merge 4 commits intoParcels-code:mainfrom
convert.nemo_to_sgrid for depthw coordinate#2626VeckoTheGecko wants to merge 4 commits intoParcels-code:mainfrom
Conversation
Also make depthw an optional coord for NEMO
VeckoTheGecko
commented
May 4, 2026
| _NEMO_EXPECTED_COORDS = [ | ||
| "glamf", | ||
| "gphif", | ||
| ] # "depthw" # TODO: Depthw needs to be available if the data has a depth dim. Refactor the whole convert module, this can surely all be handled better. |
Contributor
Author
There was a problem hiding this comment.
Note
Refactor the whole convert module, this can surely all be handled better.
Is still on my TODO list (though quite low down). I have ideas on how we can make the conversion very robust but I want that to come later.
Contributor
Author
I just did, and I think its working - though didn't have the time to wait for the run to complete. I think that's the last of the bughunting - working on perf on Wed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to getting the benchmark suite running (including the prior PR - #2605 ) this PR does the following:
test_convert.py::test_nemo_to_sgrid_with_depthtest_nemo_to_sgrid_with_depth)convertmodule to allow for thedepthwdimension to be optionally providedconvertmodule allowing for easier refactoring/overviewStill need to double check that this fixes all the problems in the benchmark repo - will do that on Wednesday. If you could review the code in the meantime that would be great @erikvansebille :)
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None used