Skip to content

Conversation

@CodexRaunak
Copy link

@CodexRaunak CodexRaunak commented Jun 16, 2024

Title

Add a feature to update and create social links on save

Description

When clicked on save it updates the respective value of the key in the socialLinks object. Updation passes through 2 checks:

  1. Valid URL
  2. Already have a link box on the home page -- It checks if the link we are updating already has a list box in the home panel.
    If the link box is already on the home page, it updates the respective key-value pair in the socialLinks object. Otherwise, it will create a new List Box by the createSocialLink function.

This helps to add only the unique links on the home page otherwise update the existing ones. Looking forward to merging the PR.

video.mp4

Issue Ticket Number

Fixes #57


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@CodexRaunak
Copy link
Author

@Param302 please review the PR and tell if any changes are to be made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Links on Save in Home Panel

1 participant