🛡️ Sentinel: [CRITICAL] Fix insecure password storage #38
Conversation
- Replaced plaintext storage of WebUI password with PBKDF2 hash - Added automatic migration from plaintext to hash on startup - Added opportunistic migration on successful login - Updated AuthManager to support verifying both legacy and hashed passwords - Updated tests to verify migration logic This fixes a critical vulnerability where the password was stored in plaintext.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🛡️ Sentinel: [CRITICAL] Fix insecure password storage
🚨 Severity: CRITICAL
💡 Vulnerability: The WebUI password was stored in plaintext in
config.json.🎯 Impact: Anyone with access to the configuration file (e.g., via backup, or local access) could read the password.
🔧 Fix: Implemented PBKDF2 hashing for the password. Added logic to automatically migrate existing plaintext passwords to hashes upon startup or successful login.
✅ Verification: Tested via updated unit tests ensuring that:
PR created automatically by Jules for task 2569334609888731543 started by @GhostTypes