Escape HTML entities in highlighted matches#6
Open
RedHeadSec wants to merge 1 commit intoPShlyundin:mainfrom
Open
Escape HTML entities in highlighted matches#6RedHeadSec wants to merge 1 commit intoPShlyundin:mainfrom
RedHeadSec wants to merge 1 commit intoPShlyundin:mainfrom
Conversation
Updated the _highlight_match method to escape HTML entities in the highlighted text.
Owner
|
Good day, thank you very much for your interest in the development of the ldap_shell project and for sending pull requests. I would like to note that you fixed the method for escaping HTML only in one compiler; there are quite a few compilers in the project. It may make sense to replace the parsing everywhere, and it would also be convenient if you could attach screenshots showing the results before and after your changes, so that it is clear what has changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the _highlight_match method to escape HTML entities in the highlighted text.